Skip to content

Fix image URLs in README - #1194

Open
Nishargo wants to merge 7 commits into
neuropsychology:masterfrom
Nishargo:master
Open

Fix image URLs in README#1194
Nishargo wants to merge 7 commits into
neuropsychology:masterfrom
Nishargo:master

Conversation

@Nishargo

@Nishargo Nishargo commented Jul 7, 2026

Copy link
Copy Markdown

Updated image URLs from 'raw.github.com' to 'raw.githubusercontent.com' in README.rst.

Updated image URLs from 'raw.github.com' to 'raw.githubusercontent.com' in README.rst.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several image links in README.rst to use raw.githubusercontent.com instead of raw.github.com. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@codecov-commenter

codecov-commenter commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.78%. Comparing base (ff419d9) to head (685fbfd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1194   +/-   ##
=======================================
  Coverage   57.78%   57.78%           
=======================================
  Files         310      310           
  Lines       15680    15680           
=======================================
+ Hits         9060     9061    +1     
+ Misses       6620     6619    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DerAndereJohannes

Copy link
Copy Markdown
Collaborator

Hi Nishargo, thank you for looking into updating the links in the repository.

A couple things to note:

  1. The links that you have provided with the uploaded images point to your fork of the repository (https://github.com/Nishargo/NeuroKit/) which would add some inconsistency to the readme.
  2. I am unsure if hosting the images of the university logos would be a good decision as they are copyrighted and most likely would not be compatible with the MIT license of this repository.

Therefore, it would make the most sense to update the university logos based on the URLs that they provide (or wikipedia or otherwise), such that we are not directly in violation.

Thanks again for your effort!

@Nishargo

Copy link
Copy Markdown
Author

Hi Johannes,

Thanks for taking the time to look at it.

You do have a point...but currently the images are breaking. I tried some other options, as they didn't work, I tried the last option to make a folder of the images and reference them. I will see how I can still make the update keeping in mind the MIT license and copyright issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants