Repository navigation
feat: generic float predictions (regressor/classifier split over SKFloat) - #67
Merged
Merged
Conversation
Continuous targets now share the model scalar F instead of forcing f64; integer targets elevate to F on demand. Companion tests cover f32 passthrough, f64 passthrough and nominal rejection.
SKRegressorPredictor<F> predicts Array1<F>; SKClassifierPredictor<F> predicts scalar-independent Array1<i64> labels plus Array2<F> probabilities. SKSupervisedFit targets bind SKTargetView<F>. Homogeneous-F stage chaining and concurrent/shared-model inference covered by companion tests.
SKSupervisedScorer scores continuous predictions in F; new SKLabelScorer scores i64 labels; unsupervised scorer rebinds to the regressor contract. Companion tests cover f32/f64, pure and convenient forms, and structured shape-mismatch errors.
Covers scalar accounting per dtype for the streaming/batch budget.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generic prediction/target/scorer contracts over
SKFloat:SKRegressorPredictor<F>returnsArray1<F>,SKClassifierPredictor<F>returnsArray1<i64>labels plusArray2<F>probabilities,SKTargetView<F>, split scorers. f32 pipelines no longer pay an f64 detour.BREAKING: removes f64-only
SKPredictorand float-encoded labels.Gates green locally:
cargo fmt --check,cargo clippy --workspace --all-targets(0 warnings),cargo test --workspace(98 + 80 passing). Independent review: APPROVE.Closes #65.