kb(skills): add link validation to kb-pr-review Derek checklist#1203
Merged
Conversation
Adds a `links` row to the Derek review table in kb-pr-review/SKILL.md. Reviewers now find every internal `/docs/...` markdown link, resolve each to a real file on disk (via the target's `slug` frontmatter override or its real path/filename — not its `sidebar_label` or `title`), and flag any mismatch as a Required fix.
Contributor
Code ReviewNo correctness, security, or build-breaking issues found. This PR adds a single links row to the review checklist in The one factual reference in the added text — that broken links are backstopped by No changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
linksrow to the Derek review table in.claude/skills/kb-pr-review/SKILL.md. Reviewers now find every internal/docs/...markdown link in an article, resolve each to a real file on disk (via the target'sslugfrontmatter override or its real path/filename — not itssidebar_labelortitle), and flag any mismatch as a Required fix. External links are out of scope.Changes
.claude/skills/kb-pr-review/SKILL.md— newlinksrow in the Step 8 Derek review-areas table, betweenimagesandformatting.