Skip to content

Add ability to set additional API parameters - #35

Open
andriykorchak wants to merge 1 commit into
netmanchris:masterfrom
andriykorchak:additional_params
Open

Add ability to set additional API parameters#35
andriykorchak wants to merge 1 commit into
netmanchris:masterfrom
andriykorchak:additional_params

Conversation

@andriykorchak

Copy link
Copy Markdown

Hi @netmanchris,

Thanks for the great library.

Please review this PR - I added ability to set additional API parameters in conn.get_data() and data.get_raw_data().

One of the possible application example - filter raw data by date/time.

Thanks,

Andrii

@netmanchris

Copy link
Copy Markdown
Owner

Hey @andriykorchak Really appreciate you adding to this. Are you comfortable adding a couple of test examples using the new params feature? It looks like the changes you made haven’t broken any of the current test which is great, but I’d like to make sure we add the new test to make sure we don’t accidentally break something in the future.

@andriykorchak

Copy link
Copy Markdown
Author

Sure, will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants