Update private core snapshot to netft-cpp v0.1.3 - #10
Merged
Conversation
📝 WalkthroughWalkthroughThe PR updates the POSIX receive timeout logic to preserve deadlines across ChangesPOSIX timeout correction and release
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/core/test_posix_transport.cpp`:
- Around line 68-82: Make the EINTR regression cases in __wrap_poll
deterministic by removing real sleep_for-based timing and using an injectable or
controllable clock/time seam in the upstream production path, then synchronize
the corresponding src/core snapshot. Preserve the intended EintrPastDeadline and
RepeatedEintrThenTimeout behaviors and the expected four-poll coverage without
relying on wall-clock scheduling.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: e2e359f9-803d-49f1-a75c-cc827b80fac6
📒 Files selected for processing (8)
CHANGELOG.rstREADME.mdpackage.xmlpixi.tomlsrc/core/UPSTREAMsrc/core/src/detail/posix_transport.cpptest/core/CMakeLists.txttest/core/test_posix_transport.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Summary by CodeRabbit
Bug Fixes
Tests
Documentation
Release