Skip to content

Update private core snapshot to netft-cpp v0.1.3 - #10

Merged
han-xudong merged 1 commit into
mainfrom
release/0.3.1
Jul 23, 2026
Merged

Update private core snapshot to netft-cpp v0.1.3#10
han-xudong merged 1 commit into
mainfrom
release/0.3.1

Conversation

@han-xudong

@han-xudong han-xudong commented Jul 23, 2026

Copy link
Copy Markdown
Member

Summary

  • update the private netft-cpp core snapshot to v0.1.3
  • preserve the configured UDP receive deadline across repeated EINTR interruptions
  • add the upstream POSIX transport regression suite
  • prepare package version 0.3.1

Verification

  • pure unit suite: 143 passed, 1 skipped
  • private core suite: 15 passed
  • Noetic build, tests, and smoke test
  • Humble, Jazzy, Kilted, Lyrical, and Rolling builds, tests, node smoke tests, and ros2_control smoke tests
  • snapshot sources and regression test match netft-cpp v0.1.3 exactly

Summary by CodeRabbit

  • Bug Fixes

    • Fixed UDP receive timeouts so repeated interruptions no longer extend the configured timeout.
    • Preserved expected handling for connection errors, invalid descriptors, interrupted reads, and oversized timeouts.
  • Tests

    • Added comprehensive coverage for interrupted polling, timeout expiration, transport errors, datagram reads, and send/receive behavior.
  • Documentation

    • Updated core provenance information and changelog details for the included upstream snapshot.
  • Release

    • Bumped the package version to 0.3.1.

@github-actions github-actions Bot added documentation Improvements or additions to documentation ci Continuous integration and repository automation driver Driver implementation and runtime behavior tests Test coverage and test infrastructure dependencies Dependency updates labels Jul 23, 2026
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The PR updates the POSIX receive timeout logic to preserve deadlines across EINTR, adds deterministic transport regression tests, and bumps package and embedded core snapshot metadata to versions 0.3.1 and v0.1.3.

Changes

POSIX timeout correction and release

Layer / File(s) Summary
Deadline-based poll interruption handling
src/core/src/detail/posix_transport.cpp
PosixTransport::receive now recalculates remaining timeout from a steady-clock deadline after interrupted poll() calls.
Transport regression coverage
test/core/CMakeLists.txt, test/core/test_posix_transport.cpp
Adds wrapped POSIX system-call tests covering interrupted polls, deadlines, errors, connection state, datagrams, and timeout saturation.
Snapshot and package version updates
src/core/UPSTREAM, package.xml, pixi.toml, README.md, CHANGELOG.rst
Records the v0.1.3 core snapshot and updates project version metadata and release documentation.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related issues

Possibly related PRs

  • netft/ros-netft#9 — Introduced the private core snapshot containing the updated PosixTransport implementation.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating the private core snapshot to netft-cpp v0.1.3.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release/0.3.1

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@test/core/test_posix_transport.cpp`:
- Around line 68-82: Make the EINTR regression cases in __wrap_poll
deterministic by removing real sleep_for-based timing and using an injectable or
controllable clock/time seam in the upstream production path, then synchronize
the corresponding src/core snapshot. Preserve the intended EintrPastDeadline and
RepeatedEintrThenTimeout behaviors and the expected four-poll coverage without
relying on wall-clock scheduling.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e2e359f9-803d-49f1-a75c-cc827b80fac6

📥 Commits

Reviewing files that changed from the base of the PR and between 33597c7 and 8b746bc.

📒 Files selected for processing (8)
  • CHANGELOG.rst
  • README.md
  • package.xml
  • pixi.toml
  • src/core/UPSTREAM
  • src/core/src/detail/posix_transport.cpp
  • test/core/CMakeLists.txt
  • test/core/test_posix_transport.cpp

Comment thread test/core/test_posix_transport.cpp
@han-xudong
han-xudong merged commit 39e3e4e into main Jul 23, 2026
21 of 23 checks passed
@han-xudong
han-xudong deleted the release/0.3.1 branch July 23, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration and repository automation dependencies Dependency updates documentation Improvements or additions to documentation driver Driver implementation and runtime behavior tests Test coverage and test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant