fix: require libcurl 7.63 for URL handles - #16
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe project version is updated to 0.2.2, the minimum required libcurl version is raised to 7.63.0, documentation is synchronized, and a CTest script validates the dependency boundary and version metadata. Changeslibcurl version update
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/curl_minimum_test.sh`:
- Around line 62-64: Add an assertion in the test script alongside the existing
CMake dependency checks to verify that pixi.toml declares libcurl with the
minimum version constraint >=7.63.0. Use the existing repo_root path and
preserve the current checks for netftConfig.cmake.in and SOVERSION.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 50170b16-ae50-4037-9a99-ee530b2fee43
📒 Files selected for processing (7)
CHANGELOG.mdCMakeLists.txtREADME.mdcmake/netftConfig.cmake.inpixi.tomltest/CMakeLists.txttest/curl_minimum_test.sh
Summary
Rationale
Sensor discovery uses
CURLOPT_CURLU. According to the official libcurl symbol documentation, that option was added in libcurl 7.63.0, so the previous 7.62 requirement could allow configuration to succeed before compilation failed.The new test uses local fake headers and archives only; it does not depend on network access, a physical sensor, or wording-oriented assertions.
SOVERSIONremains 1 and public headers are unchanged.Verification
Hardware
No physical hardware is required for this build-system compatibility correction.
Summary by CodeRabbit
Release
Bug Fixes
Documentation
Tests