Restore GCC 10 and manylinux2014 compatibility - #15
Conversation
|
Warning Review limit reached
Next review available in: 11 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe change replaces calibration-count parsing with locale-independent C++17 stream parsing, preserves floating-point state, adds coverage for numeric edge cases, introduces GCC 10 compatibility validation, updates the project to version 0.2.1, and centralizes the ATI HTTP protocol constant. ChangesCompatibility and release updates
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
test/gcc10_compatibility_test.sh (1)
18-24: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winVerify the resolved compiler is actually GCC 10.4.x before building.
The
cmake-316CI job greps the pinned CMake version to fail fast on drift; this script has no equivalent check for the pinned GCC version. If the spec ever resolves to a different compiler/version, this job would silently stop testing GCC 10 compatibility while still passing.♻️ Proposed fix to fail fast on compiler drift
cmake -S "${repo_root}" -B "${build_dir}" -G Ninja \ -DCMAKE_CXX_COMPILER=x86_64-conda-linux-gnu-c++ \ -DCMAKE_BUILD_TYPE=Release \ -DBUILD_SHARED_LIBS=ON \ -DBUILD_TESTING=ON + x86_64-conda-linux-gnu-c++ --version | grep -E "\) 10\.4\." || { + echo "expected GCC 10.4.x, got a different compiler version" >&2 + exit 1 + } cmake --build "${build_dir}"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/gcc10_compatibility_test.sh` around lines 18 - 24, Update the GCC compatibility setup before the CMake configure/build steps to resolve the selected x86_64-conda-linux-gnu-c++ compiler version and fail immediately unless it is GCC 10.4.x. Keep the existing CMake, build, and ctest flow unchanged after this validation.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@test/gcc10_compatibility_test.sh`:
- Around line 18-24: Update the GCC compatibility setup before the CMake
configure/build steps to resolve the selected x86_64-conda-linux-gnu-c++
compiler version and fail immediately unless it is GCC 10.4.x. Keep the existing
CMake, build, and ctest flow unchanged after this validation.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8c01936c-1bd6-448b-8cc3-6ed26e13b764
📒 Files selected for processing (8)
.github/workflows/ci.ymlCHANGELOG.mdCMakeLists.txtpixi.tomlsrc/detail/xml_config.cppsrc/discovery.cpptest/gcc10_compatibility_test.shtest/test_discovery.cpp
2 participants
Summary
Fix the source build failure encountered by the downstream pyNetFT manylinux2014 wheel job with GCC 10.4. The older libstdc++ provides integer but not floating-point
std::from_chars, so the calibration-count parser could not compile even though the project targets C++17.Replace that private parser with a locale-independent C++17 stream implementation while preserving the existing validation contract: complete input consumption, finite positive values, range rejection, and rejection of a leading plus sign. Parsing is isolated from the caller's floating-point environment by temporarily holding exceptions and selecting round-to-nearest, then restoring the complete environment on every success and error path.
Add a pinned GCC 10 compatibility job and regression coverage for decimals, scientific notation, locale changes, rounding modes, exception flags, and enabled glibc floating-point traps. The intentional ATI HTTP-only configuration endpoint now uses a documented source-level CodeQL suppression at the shared scheme constant;
SECURITY.mdcontinues to define the required trusted network boundary.Prepare patch release 0.2.1. Public headers and SOVERSION remain unchanged.
Testing
pixi run gcc-10-test— clean GCC 10.4 Release/shared build; 13/13 CTest targets passedpixi run test— clean default build; 13/13 CTest targets passedpixi run format-checkpixi run tidybash test/release_publish_test.shgit diff --check, and clean worktree verifiedEarlier task verification also covered GCC and Clang Debug/Release shared/static matrices, CMake 3.16 installed consumers, ASan/UBSan, and coverage generation.
Hardware
No physical sensor was contacted. The change is isolated to deterministic calibration parsing and uses the fake HTTP sensor tests.
Backports
No automatic
ros-netftbackport is included. If the ROS package needs this GCC 10 compatibility fix, it will receive a separate manual snapshot update referencing the final merged commit.Checklist
pixi run format-check,pixi run tidy, andpixi run testpass.ros-netftuse will follow the documented manual backport process.Summary by CodeRabbit
New Features
Bug Fixes
Tests