Skip to content

Expose raw wrench counts - #14

Merged
han-xudong merged 6 commits into
mainfrom
feat/raw-wrench
Jul 24, 2026
Merged

Expose raw wrench counts#14
han-xudong merged 6 commits into
mainfrom
feat/raw-wrench

Conversation

@han-xudong

@han-xudong han-xudong commented Jul 24, 2026

Copy link
Copy Markdown
Member

Summary

  • expose exact signed RDT counts on every Sample
  • preserve calibrated force and torque delivery
  • prepare the ABI-changing 0.2.0 release

Verification

  • pixi run test
  • pixi run format-check
  • pixi run tidy
  • installed shared-library consumer

Summary by CodeRabbit

  • New Features

    • Samples now include six signed raw wrench readings: force X/Y/Z and torque X/Y/Z.
    • Raw readings are available alongside calibrated force and torque values, units, and configuration details.
    • Updated streaming examples demonstrate access to raw sensor values.
  • Changed

    • Released version 0.2.0 with an updated shared-library compatibility version.
    • Package compatibility now distinguishes older 0.1 installations from the 0.2 release.
  • Documentation

    • Expanded guidance on raw readings, calibrated measurements, units, revisions, and active configuration details.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 224ecef5-dd38-41fa-8b62-315c7aab6c52

📥 Commits

Reviewing files that changed from the base of the PR and between 1f0b7a7 and 0c7c070.

📒 Files selected for processing (10)
  • .github/workflows/release.yml
  • CHANGELOG.md
  • CMakeLists.txt
  • README.md
  • include/netft/types.hpp
  • pixi.toml
  • src/detail/client_impl.cpp
  • test/consumer/CMakeLists.txt
  • test/install_test.sh
  • test/test_client_stream.cpp

📝 Walkthrough

Walkthrough

The Sample type now exposes six signed raw RDT wrench counts, populated from decoded records and covered by stream tests and documentation. Release metadata advances to 0.2.0, the shared-library ABI to version 1, package compatibility is tightened, and release tags are validated against pixi.toml.

Changes

Sample payload and release alignment

Layer / File(s) Summary
Raw wrench sample flow
include/netft/types.hpp, src/detail/client_impl.cpp, test/test_client_stream.cpp, README.md, CHANGELOG.md
Sample::raw_wrench stores force and torque RDT counts, record handling populates all six values, and tests, examples, and release notes describe the expanded payload.
0.2.0 packaging and ABI
pixi.toml, CMakeLists.txt, test/consumer/CMakeLists.txt, test/install_test.sh
Project and package metadata advance to 0.2.0, the shared-library SOVERSION becomes 1, compatibility checks target the 0.2 package, and installation checks reject the older package request.
Release tag verification
.github/workflows/release.yml
The release workflow compares the Git tag version with pixi.toml and exits with an error when they differ.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant RawRecord
  participant ClientImpl
  participant Sample
  participant Consumer
  RawRecord->>ClientImpl: Provide six decoded wrench counts
  ClientImpl->>Sample: Populate raw_wrench, force, and torque
  Sample-->>Consumer: Publish the completed sample
Loading
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change by exposing raw wrench counts on samples.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/raw-wrench

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@han-xudong
han-xudong merged commit 40a53bd into main Jul 24, 2026
17 checks passed
@han-xudong
han-xudong deleted the feat/raw-wrench branch July 26, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant