feat(proto): expose minimal User + restore user references#554
Merged
Conversation
Adds a minimal User message (username only) and restores user references dropped while User was absent: RackReservation.user plus Owner.users, JournalEntry.created_by, the generic-object *_user variants, and the CustomField.related_object_type enum. Additive only (new highest field numbers; no renumbering). Enables netboxlabs/diode-sdk-python#75. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
leoparente
force-pushed
the
feat/obs-user-rackreservation
branch
from
July 9, 2026 13:02
7e7b87a to
42420ca
Compare
Regenerate the diode-server protobuf stubs (diode/v1/diodepb/*.pb.go), the netbox server_utils.go, and docs/diode-proto.md for the new User message + restored user references (buf generate --template buf.gen.server.go.yaml; proto left in its existing compact format). Matches the file set of the prior proto-sync PR (#528). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
github-actions
Bot
added
documentation
Vulnerability Scan: Passed — diode-ingesterImage: No vulnerabilities found. Commit: 11e386f |
Vulnerability Scan: Passed — diode-reconcilerImage: No vulnerabilities found. Commit: 11e386f |
Vulnerability Scan: Passed — diode-authImage:
Commit: 11e386f |
|
Go test coverage
Total coverage: 55.1% |
leoparente
marked this pull request as ready for review
July 21, 2026 12:50
leoparente
requested review from
MicahParks,
davidlanouette,
grant-nbl,
jajeffries,
manrodrigues,
marc-barry,
mfiedorowicz and
paulstuart
as code owners
July 21, 2026 12:50
mfiedorowicz
approved these changes
Jul 21, 2026
jajeffries
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a minimal
Usermessage to the ingester proto and restores theuserreferences that were previously absent — most importantly
RackReservation.user,which NetBox requires, so rack reservations become ingestable end-to-end.
Enables netboxlabs/diode-sdk-python#75.
The
Usermessage is intentionally minimal — justusername(its natural key).It is a reference target only: consumers resolve users by username and never
create them via ingest.
What changes
message User { string username = 1; }(plus the standard metadata field).RackReservation.userrestored (required FK).userreferences restored on the other entities that reference a user:Owner.users,JournalEntry.created_by, the generic-object*_uservariants(
ContactAssignment,FHRPGroupAssignment,L2VPNTermination,TunnelTermination,GenericObject,CustomFieldObjectReference), and theCustomField.related_object_typeenum.Wire-compatible; SDK stubs regenerate identically.
The diff is kept minimal (~18 lines, matching the existing file's formatting) —
no
buf formatreflow.Downstream
The
diode-sdk-python/diode-sdk-gostubs regenerate from this proto (separatePRs). Server stubs and image rebuilds are out of scope here.