🚚 release#364
Merged
Merged
Conversation
mfiedorowicz
requested review from
jajeffries,
leoparente and
ltucker
as code owners
June 11, 2025 16:36
|
Go test coverage
Total coverage: 48.3% |
ltucker
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces multiple updates across Helm chart configurations, documentation, and workflows to enhance usability, maintainability, and functionality. Key changes include the addition of annotations and labels for Kubernetes resources, improvements to Helm linting workflows, and comprehensive documentation updates for the Diode service.
Helm Chart Updates:
charts/diode/Chart.yaml: Updated the chart version from1.5.0to1.6.0.charts/diode/templates/_helpers.tpl: Added support forglobal.commonLabelsto standardize labels across resources.cert-issuer.yaml,diode-auth-bootstrap-job.yaml,diode-auth-configmap.yaml,diode-auth-deployment.yaml): Introducedglobal.commonAnnotationsand resource-specific annotations for enhanced metadata management. [1] [2] [3] [4]Workflow Improvements:
.github/workflows/configs/helm-ct.yaml: Added new configuration options (validate-maintainersandskip-helm-dependencies) for chart-testing workflows..github/workflows/helm-lint.yaml: Refactored the Helm lint workflow to include dependency extraction, repository addition, and chart-testing steps. Updated action versions for improved compatibility.Documentation Enhancements:
GET_STARTED.md: Added a detailed "Getting Started" guide for deploying and configuring the Diode service, NetBox plugin, and Orb agent for data ingestion.README.md: Streamlined content with updated project status, prerequisites, and quick-start instructions, linking to the new guide.Helm Chart Values:
charts/diode/README.md: Updated values documentation to include new configuration options such as annotations for deployments (diodeAuth.annotations,diodeIngester.annotations,diodeReconciler.annotations) and global metadata (global.commonAnnotations,global.commonLabels). [1] [2] [3] [4]