Skip to content

Fix SELinux policy - #26

Merged
jnfrati merged 2 commits into
netbirdio:mainfrom
PizzaLovingNerd:main
Jul 10, 2026
Merged

Fix SELinux policy#26
jnfrati merged 2 commits into
netbirdio:mainfrom
PizzaLovingNerd:main

Conversation

@PizzaLovingNerd

@PizzaLovingNerd PizzaLovingNerd commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Fixes:
SELinux

Summary by CodeRabbit

  • Bug Fixes
    • Improved SELinux compatibility for NetworkManager integration, helping the app read required system information without access errors.

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@PizzaLovingNerd, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 37 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 71432df8-b87d-462b-a75a-aae5960fb5d3

📥 Commits

Reviewing files that changed from the base of the PR and between a6f95c6 and 2c0427b.

📒 Files selected for processing (1)
  • packaging/selinux/nm_netbird.te
📝 Walkthrough

Walkthrough

The SELinux policy module nm_netbird.te is modified to declare sysfs_t in its require block and add an allow rule granting nm_netbird_t read access to sysfs_t file objects.

Changes

SELinux Policy Update

Layer / File(s) Summary
Add sysfs_t read permission
packaging/selinux/nm_netbird.te
Adds sysfs_t to the require block and allows nm_netbird_t to read sysfs_t:file objects.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

A tiny tweak, a policy line,
sysfs_t now reads just fine.
nm_netbird hops through with ease,
No denials, just SELinux breeze. 🐇
Carrots and permissions, both refined!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is missing the required Description and Validation sections from the template. Add a Description section and a Validation section with the required checkbox, or explain why they are omitted.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: a SELinux policy fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
packaging/selinux/nm_netbird.te (1)

1-1: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Consider bumping the policy module version.

New permissions were added but the module version remains 1.0.1. Bumping to 1.0.2 follows the convention of incrementing on policy changes and helps track which policy revision is deployed.

🔖 Suggested version bump
-policy_module(nm_netbird, 1.0.1)
+policy_module(nm_netbird, 1.0.2)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packaging/selinux/nm_netbird.te` at line 1, Bump the SELinux policy module
version in policy_module for nm_netbird from 1.0.1 to 1.0.2. Update the version
string in the policy_module declaration so the nm_netbird policy reflects the
added permissions and matches the expected revisioning convention.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@packaging/selinux/nm_netbird.te`:
- Line 1: Bump the SELinux policy module version in policy_module for nm_netbird
from 1.0.1 to 1.0.2. Update the version string in the policy_module declaration
so the nm_netbird policy reflects the added permissions and matches the expected
revisioning convention.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7225ab08-cb11-48bb-b0d0-311fbbccc2f7

📥 Commits

Reviewing files that changed from the base of the PR and between 8a3ed05 and a6f95c6.

📒 Files selected for processing (1)
  • packaging/selinux/nm_netbird.te

@jnfrati
jnfrati merged commit 8260f74 into netbirdio:main Jul 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants