Skip to content

chore: publish packages to NetBird repositories - #25

Merged
jnfrati merged 2 commits into
mainfrom
chore/publish-packages-to-repos
Jul 10, 2026
Merged

chore: publish packages to NetBird repositories#25
jnfrati merged 2 commits into
mainfrom
chore/publish-packages-to-repos

Conversation

@jnfrati

@jnfrati jnfrati commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Description

  • Publish .deb and .rpm release artifacts to the NetBird APT/YUM repositories from GoReleaser.
  • Split nfpm package definitions by format so uploads can target distinct artifact IDs and use distro-specific dependencies.
  • Update release workflow secrets and package repository install/upgrade docs.

Validation

  • task quality:full for risky changes (not run locally)
  • go test ./...
  • git diff --check

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Added separate Debian and RPM packaging/publishing flows for release artifacts.
  • Documentation

    • Expanded installation requirements and quick-install steps for repository-based installs and the network-manager-netbird APT/YUM packages.
    • Updated upgrade and uninstall instructions to use package-manager commands.
    • Clarified installed file layout for repository packages and tarball installs.
  • Build/Release

    • Enhanced release publishing configuration to support the expanded artifact upload setup.

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 897693bc-083e-44ad-92da-794ae40f078c

📥 Commits

Reviewing files that changed from the base of the PR and between 4eaf472 and 90e7a74.

📒 Files selected for processing (1)
  • .goreleaser.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .goreleaser.yml

📝 Walkthrough

Walkthrough

The GoReleaser configuration separates Debian and RPM packages with format-specific dependencies, payloads, scripts, and upload targets. CI supplies separate upload variables, while README and reference documentation describe APT/YUM repository installation and upgrades.

Changes

Package split and documentation update

Layer / File(s) Summary
Split nfpm into deb and rpm entries with uploads
.goreleaser.yml
Replaces the combined package definition with linux-packages-deb and linux-packages-rpm, and updates Debian and Yum uploads to use the corresponding package ids and extensions.
Inject Debian and Yum upload secrets in CI
.github/workflows/release.yml
Adds UPLOAD_DEBIAN_SECRET and UPLOAD_YUM_SECRET, both mapped from secrets.PKG_UPLOAD_SECRET.
Update installation and package documentation
README.md, docs/reference.md
Revises requirements, APT/YUM installation, snapshot, upgrade, uninstall, and installed-file guidance for repository packages.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Poem

🐇 Two package paths now hop along,
Debian and RPM each sing their song.
Secrets guide releases through the night,
APT and YUM install just right.
The docs now point the way—
Ship cleanly today! 📦

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: publishing packages to NetBird repositories.
Description check ✅ Passed The description matches the template with Description and Validation sections and includes the required checks.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/publish-packages-to-repos

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.goreleaser.yml:
- Around line 247-258: The archive upload targets in the goreleaser config are
templating architecture from values that are empty in archive mode, so fix the
Debian and yum upload entries to use explicit architecture values instead of
`.Arch`/`.Arm`. Update the affected release targets in the archive upload
section so the Debian `deb.architecture` and yum path resolve to the intended
fixed architectures, or change the upload mode only if dynamic templating is
actually required.

In `@README.md`:
- Around line 27-64: The README repository install instructions use the wrong
package domain, so update the APT and YUM URLs in the documented install steps
to match the actual GoReleaser upload targets used for the package artifacts.
Check the repository install sections that mention `pkgs.netbird.io` and align
them with the canonical domain used by the release pipeline (or adjust the
release config if that domain is intended), so the `curl`, `deb`, and `repo`
references all point to the same host.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e5a3f6df-b469-40bd-86d0-64502e59ba66

📥 Commits

Reviewing files that changed from the base of the PR and between 8a3ed05 and 4eaf472.

📒 Files selected for processing (4)
  • .github/workflows/release.yml
  • .goreleaser.yml
  • README.md
  • docs/reference.md

Comment thread .goreleaser.yml Outdated
Comment thread README.md
@jnfrati
jnfrati merged commit ee86862 into main Jul 10, 2026
5 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant