Skip to content

Add websocket paths including relay to nginx template - #4573

Merged
lixmal merged 1 commit into
mainfrom
nginx-ws-template
Oct 2, 2025
Merged

Add websocket paths including relay to nginx template#4573
lixmal merged 1 commit into
mainfrom
nginx-ws-template

Conversation

@lixmal

@lixmal lixmal commented Oct 2, 2025

Copy link
Copy Markdown
Collaborator

Describe your changes

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

netbirdio/docs#439

Copilot AI review requested due to automatic review settings October 2, 2025 11:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds websocket support to the nginx configuration template by introducing a new relay upstream and adding websocket-specific headers to existing and new proxy locations.

  • Added relay upstream configuration pointing to port 33080
  • Added websocket headers (Upgrade, Connection, Host) to signal and management ws-proxy endpoints
  • Added new /relay location with websocket support

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread infrastructure_files/nginx.tmpl.conf
Comment thread infrastructure_files/nginx.tmpl.conf
@sonarqubecloud

sonarqubecloud Bot commented Oct 2, 2025

Copy link
Copy Markdown

@lixmal
lixmal merged commit e7b5537 into main Oct 2, 2025
40 of 41 checks passed
@lixmal
lixmal deleted the nginx-ws-template branch October 2, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants