Allow X-Stream-Protocol-Version so SPDY streaming works - #38
Open
Wouter0100 wants to merge 1 commit into
Open
Conversation
The header allowlist permits the Sec-Websocket-* handshake headers but not X-Stream-Protocol-Version, so every request on the SPDY streaming transport had its protocol negotiation header stripped and was rejected by the API server with: unable to upgrade connection: unable to upgrade: X-Stream-Protocol-Version is required This breaks kubectl exec, attach and cp whenever the WebSocket transport is not used: clients older than 1.30, clients with KUBECTL_REMOTE_COMMAND_WEBSOCKETS=false, and clients that fall back to SPDY because a proxy-url is configured. It also breaks kubectl port-forward against API servers without WebSocket port-forward support, since SPDY is the only transport left there. The failure is easy to misread, because kubectl attempts WebSocket first and falls back to SPDY: the real error from the first attempt is discarded and the API server answers the SPDY request with a 400 whose body is not a Status object, which kubectl renders as a bare "Error from server:" with no message.
📝 WalkthroughWalkthroughThe proxy now defines and preserves the ChangesStream protocol header forwarding
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
|
We're running this on production, works flawless. Improves compatibility with older clusters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header allowlist permits the Sec-Websocket-* handshake headers but not X-Stream-Protocol-Version, so every request on the SPDY streaming transport had its protocol negotiation header stripped and was rejected by the API server with:
unable to upgrade connection: unable to upgrade:
X-Stream-Protocol-Version is required
This breaks kubectl exec, attach and cp whenever the WebSocket transport is not used: clients older than 1.30, clients with KUBECTL_REMOTE_COMMAND_WEBSOCKETS=false, and clients that fall back to SPDY because a proxy-url is configured. It also breaks kubectl port-forward against API servers without WebSocket port-forward support, since SPDY is the only transport left there.
The failure is easy to misread, because kubectl attempts WebSocket first and falls back to SPDY: the real error from the first attempt is discarded and the API server answers the SPDY request with a 400 whose body is not a Status object, which kubectl renders as a bare "Error from server:" with no message.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit