fix: clear lingering IPv6 blackhole after exit node deselect

[CicerBro]

What this fixes

After deselecting an IPv6 exit node, traffic could still hit a leftover ::/0 blackhole. NEPacketTunnelNetworkSettings keeps the previous IPv6 configuration when the IPv6 property is left nil on the next setTunnelNetworkSettings call, so the exit-node routes never fully cleared.

Change

Always assign an explicit empty IPv6 settings object when there is no IPv6 config, forcing the system to drop the previous blackhole.

Closes

• Closes [tvOS] Exit routing and interface broken #188
• Closes tvOS: Exit routing and app UI totally broken netbird#7132
• Exit node routing inconsistent on iPhone and Apple TV netbird#6840

Summary by CodeRabbit

• Bug Fixes
  • Prevented outdated IPv6 configuration from being retained when IPv6 routing is not required.
  • Tunnel settings now correctly clear IPv6 configuration when applicable.

[coderabbitai]

📝 Walkthrough

Walkthrough

createTunnelSettings now assigns empty IPv6 settings when no IPv6 address or default-route blackhole is required. This prevents previously applied IPv6 configuration from remaining active.

Changes

IPv6 tunnel settings

Layer / File(s)	Summary
Clear unused IPv6 configuration NetbirdNetworkExtension/PacketTunnelProviderSettingsManager.swift	createTunnelSettings assigns empty NEIPv6Settings when no IPv6 configuration is required.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related issues

• tvOS: Exit routing and app UI totally broken netbird#7132 — Both changes address stale IPv6 and exit-routing state in the Apple network tunnel.

Possibly related PRs

• netbirdio/ios-client#128 — Both changes update PacketTunnelProvider IPv6 default-route handling and clearing behavior.

Suggested reviewers: lixmal

Poem

A rabbit hops through IPv6 snow,
Finds old routes that should not show.
Empty settings clear the way,
Fresh tunnel paths begin today.
Hop, hop, no stale tracks remain!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The change addresses the linked tvOS routing failures by clearing retained IPv6 blackhole settings after exit node deselection [#188, #7132].
Out of Scope Changes check	✅ Passed	The six added lines are limited to clearing stale IPv6 tunnel settings and align with the linked routing objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title clearly and concisely describes the fix for the lingering IPv6 blackhole after exit node deselection.
Description check	✅ Passed	The description explains the issue, cause, fix, and linked references, but uses custom headings instead of the template's ## Description heading.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

This PR addresses a tvOS-specific NetworkExtension behavior where leaving NEPacketTunnelNetworkSettings.ipv6Settings as nil can cause the system to retain previously-applied IPv6 configuration (including a lingering ::/0 blackhole) after an IPv6 exit node is deselected.

Changes:

• Updates tunnel settings construction to always set ipv6Settings even when there is no active IPv6 configuration, aiming to force the system to clear stale IPv6 state.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[pappz]

@CicerBro please update the title of the PR. The patch valid for tv and iOS too

[pappz]

/testflight

[github-actions]

TestFlight builds uploaded 0.3.4 (22) for 4a53cf3 — iOS + tvOS

View workflow run