Skip to content

Add appProtocol field to Services #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vehagn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add appProtocol field to Services #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions charts/netbird/templates/dashboard-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ spec:
targetPort: http
protocol: TCP
name: http
{{- if .Values.dashboard.service.appProtocol }}
appProtocol: {{ .Values.dashboard.service.appProtocol }}
{{- end }}
selector:
{{- include "netbird.dashboard.selectorLabels" . | nindent 4 }}
{{- with .Values.dashboard.service.externalIPs }}
Expand Down
3 changes: 3 additions & 0 deletions charts/netbird/templates/management-service-grpc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ spec:
targetPort: {{ .Values.management.serviceGrpc.name }}
protocol: TCP
name: {{ .Values.management.serviceGrpc.name }}
{{- if .Values.management.serviceGrpc.appProtocol }}
appProtocol: {{ .Values.management.serviceGrpc.appProtocol }}
{{- end }}
selector:
{{- include "netbird.management.selectorLabels" . | nindent 4 }}
{{- with .Values.management.serviceGrpc.externalIPs }}
Expand Down
3 changes: 3 additions & 0 deletions charts/netbird/templates/management-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ spec:
targetPort: {{ .Values.management.service.name }}
protocol: TCP
name: {{ .Values.management.service.name }}
{{- if .Values.management.service.appProtocol }}
appProtocol: {{ .Values.management.service.appProtocol }}
{{- end }}
{{- if .Values.management.metrics.enabled }}
- port: {{ .Values.management.metrics.port }}
targetPort: metrics
Expand Down
3 changes: 3 additions & 0 deletions charts/netbird/templates/relay-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ spec:
targetPort: {{ .Values.relay.service.name }}
protocol: TCP
name: {{ .Values.relay.service.name }}
{{- if .Values.relay.service.appProtocol }}
appProtocol: {{ .Values.relay.service.appProtocol }}
{{- end }}
{{- if .Values.relay.metrics.enabled }}
- port: {{ .Values.relay.metrics.port}}
targetPort: metrics
Expand Down
3 changes: 3 additions & 0 deletions charts/netbird/templates/signal-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ spec:
targetPort: {{ .Values.signal.service.name }}
protocol: TCP
name: {{ .Values.signal.service.name }}
{{- if .Values.signal.service.appProtocol }}
appProtocol: {{ .Values.signal.service.appProtocol }}
{{- end }}
{{- if .Values.signal.metrics.enabled }}
- port: {{ .Values.signal.metrics.port }}
targetPort: metrics
Expand Down
20 changes: 20 additions & 0 deletions charts/netbird/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,10 @@ management:
##
name: http

## @param management.service.appProtocol AppProtocol for the management service port.
##
appProtocol: kubernetes.io/h2c

## @param management.service.externalIPs External IPs for the management service.
##
externalIPs: []
Expand All @@ -163,6 +167,10 @@ management:
##
name: grpc

## @param management.serviceGrpc.appProtocol AppProtocol for the management GRPC service port.
##
appProtocol: kubernetes.io/h2c

## @param management.serviceGrpc.externalIPs External IPs for the management GRPC service.
##
externalIPs: []
Expand Down Expand Up @@ -397,6 +405,10 @@ signal:
##
name: grpc

## @param signal.service.appProtocol AppProtocol for the signal service port.
##
appProtocol: kubernetes.io/h2c

## @param signal.service.externalIPs External IPs for the signal service.
##
externalIPs: []
Expand Down Expand Up @@ -590,6 +602,10 @@ relay:
##
name: http

## @param relay.service.appProtocol AppProtocol for the relay service port.
##
appProtocol: ""

## @param relay.service.externalIPs External IPs for the relay service.
##
externalIPs: []
Expand Down Expand Up @@ -755,6 +771,10 @@ dashboard:
##
name: http

## @param dashboard.service.appProtocol AppProtocol for the dashboard service port.
##
appProtocol: ""

## @param dashboard.service.externalIPs External IPs for the dashboard service.
##
externalIPs: []
Expand Down