Skip to content

Fix .videowrapper and update button and search components for consistency in text labels #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mlsmaycon merged 2 commits into from
Nov 22, 2025
Merged

Fix .videowrapper and update button and search components for consistency in text labels #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3485a3f
Update button and search components for consistency in text labels
TechHutTV Nov 21, 2025
ab41a57
Fix videowrapper
TechHutTV Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Button.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export function Button({
let Component = props.href ? Link : 'button'

className = clsx(
'inline-flex gap-0.5 justify-center overflow-hidden text-sm font-medium transition',
'inline-flex gap-0.5 justify-center overflow-hidden text-sm font-medium transition whitespace-nowrap',
variantStyles[variant],
className
)
Expand Down
10 changes: 5 additions & 5 deletions src/components/Search.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ function useAutocomplete() {
let [autocomplete] = useState(() =>
createAutocomplete({
id,
placeholder: 'Find something...',
placeholder: 'Search...',
defaultActiveItemId: 0,
onStateChange({ state }) {
setAutocompleteState(state)
Expand Down Expand Up @@ -307,7 +307,7 @@ function SearchButton(props) {
{...props}
>
<SearchIcon className="h-5 w-5 stroke-current" />
Find something...
Search...
<kbd className="ml-auto text-2xs text-zinc-400 dark:text-zinc-500">
<kbd className="font-sans">{modifierKey}</kbd>
<kbd className="font-sans">K</kbd>
Expand All @@ -316,7 +316,7 @@ function SearchButton(props) {
<button
type="button"
className="flex h-6 w-6 items-center justify-center rounded-md transition hover:bg-zinc-900/5 dark:hover:bg-white/5 lg:hidden focus:[&:not(:focus-visible)]:outline-none"
aria-label="Find something..."
aria-label="Search..."
{...props}
>
<SearchIcon className="h-5 w-5 stroke-zinc-900 dark:stroke-white" />
Expand Down Expand Up @@ -485,7 +485,7 @@ export function Search() {
{...buttonProps}
>
<SearchIcon className="h-5 w-5 stroke-current" />
Find something...
Search...
<kbd className="ml-auto text-2xs text-zinc-400 dark:text-zinc-500">
<kbd className="font-sans">{modifierKey}</kbd>
<kbd className="font-sans">K</kbd>
Expand All @@ -504,7 +504,7 @@ export function MobileSearch() {
<button
type="button"
className="flex h-6 w-6 items-center justify-center rounded-md transition hover:bg-zinc-900/5 dark:hover:bg-white/5 lg:hidden focus:[&:not(:focus-visible)]:outline-none"
aria-label="Find something..."
aria-label="Search..."
{...buttonProps}
>
<SearchIcon className="h-5 w-5 stroke-zinc-900 dark:stroke-white" />
Expand Down
50 changes: 38 additions & 12 deletions src/styles/tailwind.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,39 +53,65 @@
}

.videowrapper {
float: none;
clear: both;
width: 100%;
position: relative;
padding-bottom: 46.25%;
padding-top: 25px;
height: 0;
width: 100%;
aspect-ratio: 16 / 9;
overflow: hidden;
margin-left: 10px;
margin-right: auto;
}

@media (max-width: 1024px) {
.videowrapper {
max-width: 40rem; /* matches prose max-width-2xl */
}
}

@media (min-width: 1024px) {
.videowrapper {
max-width: 50rem; /* matches prose max-width-3xl */
}
}

.videowrapper iframe {
position: absolute;
top: 0;
left: 0;
width: 100%;
height: 100%;
border-radius: 4px;
border: 0;
}

.videowrapperadjusted {
float: none;
clear: both;
width: 100%;
position: relative;
padding-bottom: 30%;
padding-top: 25px;
height: 0;
width: 100%;
aspect-ratio: 16 / 9;
overflow: hidden;
margin-left: 10px;
margin-right: auto;
}

@media (max-width: 1024px) {
.videowrapperadjusted {
max-width: 40rem; /* matches prose max-width-2xl */
}
}

@media (min-width: 1024px) {
.videowrapperadjusted {
max-width: 50rem; /* matches prose max-width-3xl */
}
}

.videowrapperadjusted iframe {
position: absolute;
top: 0;
left: 0;
width: 100%;
height: 100%;
border-radius: 4px;
border: 0;
}

.Toastify__close-button {
Expand Down