Skip to content

Browser Client Backend - #436

Merged
SunsetDrifter merged 2 commits into
mainfrom
browser-client-management
Oct 1, 2025
Merged

Browser Client Backend#436
SunsetDrifter merged 2 commits into
mainfrom
browser-client-management

Conversation

@pascal-fischer

Copy link
Copy Markdown
Collaborator
Screenshot 2025-10-01 at 17 06 58

Copilot AI review requested due to automatic review settings October 1, 2025 15:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation for the backend architecture of the Browser Client, specifically detailing how the NetBird management server supports browser client functionality through temporary resources.

  • Adds documentation for temporary peer registration and lifecycle management
  • Documents temporary policy creation for browser client access control
  • Includes visual references to management server UI elements for temporary resources

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

</p>

#### Temporary Policy
To allow the registered WebAssembly NetBird Client to connect to the target peer, a temporary policy will be created. The temporary policy will allow access to the target peer on ports 22 (SSH), 3389 (RDP), or 44338 (NetBird SSH server).

Copilot AI Oct 1, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port 44338 is described as 'NetBird SSH server' but this may be confusing since port 22 is already mentioned for SSH. Consider clarifying what service runs on port 44338 or if this refers to a specific NetBird SSH proxy service.

Suggested change
To allow the registered WebAssembly NetBird Client to connect to the target peer, a temporary policy will be created. The temporary policy will allow access to the target peer on ports 22 (SSH), 3389 (RDP), or 44338 (NetBird SSH server).
To allow the registered WebAssembly NetBird Client to connect to the target peer, a temporary policy will be created. The temporary policy will allow access to the target peer on ports 22 (standard SSH), 3389 (RDP), or 44338 (NetBird embedded SSH server for browser client access).

Copilot uses AI. Check for mistakes.
#### Temporary Policy
To allow the registered WebAssembly NetBird Client to connect to the target peer, a temporary policy will be created. The temporary policy will allow access to the target peer on ports 22 (SSH), 3389 (RDP), or 44338 (NetBird SSH server).
The policy will be created P2P with no groups required. This way the client will only connect to one other peer. Once either of the peers (source or destination) is removed, the temporary policy will be automatically removed from the management server.
The policies for the WebAssembly NetBird Client will be named as `Temporary access policy for peer *` (e.g. `Temporary access policy for peer safari-17-browser-client`).

Copilot AI Oct 1, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The asterisk (*) in the policy naming pattern could be clearer. Consider using a more explicit placeholder like {peer-name} or <peer-name> to make it obvious that this represents the actual peer name.

Suggested change
The policies for the WebAssembly NetBird Client will be named as `Temporary access policy for peer *` (e.g. `Temporary access policy for peer safari-17-browser-client`).
The policies for the WebAssembly NetBird Client will be named as `Temporary access policy for peer {peer-name}` (e.g. `Temporary access policy for peer safari-17-browser-client`).

Copilot uses AI. Check for mistakes.
@SunsetDrifter
SunsetDrifter merged commit 937018f into main Oct 1, 2025
1 check passed
@SunsetDrifter
SunsetDrifter deleted the browser-client-management branch October 1, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants