Skip to content

expose TOTP setup key during enrollment - #9

Open
slashmili wants to merge 1 commit into
netbirdio:masterfrom
slashmili:expose-toto-secret-netbird
Open

expose TOTP setup key during enrollment#9
slashmili wants to merge 1 commit into
netbirdio:masterfrom
slashmili:expose-toto-secret-netbird

Conversation

@slashmili

Copy link
Copy Markdown

Overview

Expose TOPT key during enrollment

What this PR does / why we need it

The idea is to allow showing TOTP code for users whom are not able to scan qr code or prefer to use the code in password managers.

I’m not changing the templates because downstream consumers such as NetBird provide their own web templates and own the presentation layer. This change only exposes the setup secret as TotpKey during unconfirmed TOTP enrollment, allowing those consumers to render a manual setup option alongside the QR code.

Special notes for your reviewer

I see that this repo is around 100 commits behind the upstream. Therefore i'm creating a PR in netbird's fork. I also created a similar PR in the original repo dexidp#4976

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Important

Review available on request

  • 🔍 Trigger review

Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment @coderabbitai review to review the latest changes. For a full review, comment @coderabbitai full review.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 82445cbd-c308-4dd3-affd-5268e24292bb


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant