Skip to content

added logging of effective grant types - #7

Closed
dmitri-netbird wants to merge 1 commit into
masterfrom
dmitri-grant-type-logging
Closed

added logging of effective grant types#7
dmitri-netbird wants to merge 1 commit into
masterfrom
dmitri-grant-type-logging

Conversation

@dmitri-netbird

@dmitri-netbird dmitri-netbird commented Jul 17, 2026

Copy link
Copy Markdown

Overview

What this PR does / why we need it

Special notes for your reviewer


View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Bug Fixes
    • Improved validation when enabling device authorization endpoints.
    • Added debug logging to help diagnose supported authorization grants during server startup.

Signed-off-by: Dmitri Dolguikh <dmitri.external@netbird.io>
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d78b6c88-d73d-4274-9538-fc3e1a7328da

📥 Commits

Reviewing files that changed from the base of the PR and between a163de3 and 8c11a69.

📒 Files selected for processing (1)
  • server/server.go

📝 Walkthrough

Walkthrough

newServer now logs the computed supported grants at debug level and uses slices.Contains when determining whether to register device endpoints.

Changes

Server setup

Layer / File(s) Summary
Server initialization and device registration
server/server.go
newServer logs the supported grants and uses slices.Contains to gate device endpoint registration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: pascal-fischer

Poem

I’m a rabbit reviewing the grant,
Debug logs now tell what they can.
Device routes hop when allowed,
With slices.Contains clearly avowed.
Two tiny changes, neatly planned!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: logging the effective grant types during server initialization.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dmitri-grant-type-logging

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dmitri-netbird
dmitri-netbird deleted the dmitri-grant-type-logging branch July 17, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant