Skip to content

feat(PL-6792): configurable env pattern#6

Open
silphid wants to merge 1 commit into
masterfrom
feat/PL-6792/configurable-env-pattern
Open

feat(PL-6792): configurable env pattern#6
silphid wants to merge 1 commit into
masterfrom
feat/PL-6792/configurable-env-pattern

Conversation

@silphid

@silphid silphid commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

We need to be able to progressively roll out the operator’s management of different environments. Currently, it’s hardcoded to watch all environments in catalog.

We can now configure a value like environments/{dev,demo}/env.yaml to selectively target dev and demo envs.

Summary by CodeRabbit

  • New Features
    • Added configurable environment source file patterns for catalog deployments.
    • The default pattern is environments/*/env.yaml.
    • Helm chart deployments can now override this pattern through configuration.

@silphid silphid requested a review from davidmdm July 10, 2026 21:32
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d980117d-419d-43cf-97ed-6ccbe3c77a93

📥 Commits

Reviewing files that changed from the base of the PR and between b7b9a0e and 2a47b7c.

📒 Files selected for processing (5)
  • chart/templates/deployment.yaml
  • chart/values.yaml
  • cmd/operator/conf.go
  • cmd/operator/main.go
  • cmd/operator/reconciler_catalog.go

📝 Walkthrough

Walkthrough

The operator now accepts a configurable environment source glob through Helm and ENV_SOURCE_PATTERN, passes it to catalog reconciliation, and uses it for Argo CD application source inclusion.

Changes

Environment source pattern

Layer / File(s) Summary
Environment pattern configuration
chart/values.yaml, chart/templates/deployment.yaml, cmd/operator/conf.go
Adds the Helm setting and renders ENV_SOURCE_PATTERN; operator configuration reads it with a default of environments/*/env.yaml.
Catalog reconciler integration
cmd/operator/main.go, cmd/operator/reconciler_catalog.go
Passes EnvSourcePattern into the catalog reconciler and uses it instead of the hardcoded Argo CD include pattern.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Helm
  participant OperatorConfig
  participant CatalogReconciler
  participant ArgoCD
  Helm->>OperatorConfig: provide ENV_SOURCE_PATTERN
  OperatorConfig->>CatalogReconciler: pass EnvSourcePattern
  CatalogReconciler->>ArgoCD: set source directory Include
Loading
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: making the environment pattern configurable.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/PL-6792/configurable-env-pattern

Comment @coderabbitai help to get the list of available commands.

Comment thread chart/values.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants