feat(PL-6792): configurable env pattern#6
Open
silphid wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe operator now accepts a configurable environment source glob through Helm and ChangesEnvironment source pattern
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant Helm
participant OperatorConfig
participant CatalogReconciler
participant ArgoCD
Helm->>OperatorConfig: provide ENV_SOURCE_PATTERN
OperatorConfig->>CatalogReconciler: pass EnvSourcePattern
CatalogReconciler->>ArgoCD: set source directory Include
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
davidmdm
reviewed
Jul 11, 2026
davidmdm
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to be able to progressively roll out the operator’s management of different environments. Currently, it’s hardcoded to watch all environments in catalog.
We can now configure a value like
environments/{dev,demo}/env.yamlto selectively target dev and demo envs.Summary by CodeRabbit
environments/*/env.yaml.