feat(typeorm): standardize transaction isolation levels - #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeOrmCrudTransactionIsolationLevelstring enum with a same-name const object and derived union typeReadCommitted/RepeatableReadmember syntaxCompatibility
This intentionally changes the runtime string values from lowercase to TypeORM-native uppercase. Member-based consumers keep the same source syntax, while consumers persisting or comparing the old lowercase values must migrate. The supported CRUD subset remains
READ COMMITTEDandREPEATABLE READ.Verification
pnpm exec tsc --noEmitpnpm run checkpnpm run test(323 tests)PG_URL=postgresql://nestm:nestm@localhost:55435/nestm_crud pnpm run test:postgres(65 tests)pnpm run verify:packpnpm run verify:consumer