test(core): add unit tests for module-ref - #17401
Open
Se3do wants to merge 1 commit into
Open
Conversation
Covers: - introspect() for DEFAULT, REQUEST, and TRANSIENT scopes - registerRequestByContextId() delegation - instantiateClass() with dependency resolution and error propagation - find() for single, request-scoped, and multi-instance lookups - resolve() for static, transient (unique per context), and request-scoped providers
Coverage Report for CI Build 0Coverage increased (+0.01%) to 90.317%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
ModuleRef(inpackages/core/injector/module-ref.ts) has zero dedicated unit tests. Its methods (introspect,registerRequestByContextId,instantiateClass,find,resolve) are only covered indirectly throughNestApplicationContextintegration tests.Issue Number: N/A
What is the new behavior?
Adds
packages/core/test/injector/module-ref.spec.tswith 12 tests covering:introspect()— returns correct scope for DEFAULT, REQUEST, and TRANSIENT providersregisterRequestByContextId()— delegates to containerinstantiateClass()— resolves dependencies and propagates errorsfind()— single lookup, request-scoped rejection, multi-instance witheach: trueresolve()— static, transient (unique per context), and request-scoped resolutionAll existing tests continue to pass.
Does this PR introduce a breaking change?
Other information