Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions .github/PULL_REQUEST_TEMPLATE/dev_template.md

This file was deleted.

30 changes: 26 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE/prod_template.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,31 @@
## Dev → Prod Promotion Checklist
<!-- PR template for promoting from dev to prod -->

---

## Description

### Pipeline description
<!-- Which pipeline(s) does this promote? What changed? -->

## Type of promotion
- [ ] Existing pipeline - code/data update
- [ ] New pipeline - first promotion to prod

## Instructions for reviewer

<!-- Anything they should pay particular attention to -->

## Checklist

### Pipeline run
- [ ] Manual pipeline run completed successfully on dev after merging to dev
- [ ] Manual pipeline run completed successfully on dev after merging to dev (link the run below)
- [ ] Dev S3 output spot-checked; row counts and values look reasonable
- [ ] No unexpected nulls or schema changes in output parquet files

### Image freshness
- [ ] `dev-latest` in ECR was rebuilt from the tip of `dev` that includes this PR's changes
(check the "Build and push Docker Image to ECR" run in Actions, as promotion only re-tags
the existing image, it doesn't rebuild)

### Code quality
- [ ] run-tests workflow passed on this PR
- [ ] No hardcoded credentials or environment-specific values
Expand All @@ -17,5 +35,9 @@
- [ ] No changes to silver/gold dataset column names or types that would break Superset
<!-- If there are column/type changes, describe them here and provide instructions on changes needed in Superset -->

### Notes
### After merging
- [ ] Trigger the "Run pipeline in prod" workflow to actually refresh prod data — merging this
PR only re-tags the image, it does not run the pipeline. Requires approval from at least one of named CODEOWNERS.

## Notes
<!-- Any context the approver should know before merging -->
31 changes: 31 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<!-- PR template for merges to dev -->

---

## Description

<!-- What does this change, and why? -->

Fixes # <!-- Issue number -->

## Type of change

- [ ] New pipeline
- [ ] Change to an existing pipeline
- [ ] Package / infrastructure change
- [ ] Docs only

## Checklist

- [ ] `uv run pytest` passes locally
- [ ] `uv run pre-commit run --all-files` passes (ruff, gitleaks, etc.)
- [ ] If this adds a new pipeline: it's registered in `pipelines.yaml` and has its own `README.md`
- [ ] I've merged the latest `dev` into this branch

## Testing notes

<!-- How did you verify this works? e.g. ran locally with `--stage all`, ran via the "Test pipeline in dev" GitHub Actions workflow -->

## Instructions for reviewer

<!-- Anything they should pay particular attention to -->
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ infrastructure/.env
*.parquet
/data/

# Notebooks
# Scratch notebooks aren't meant to be committed — see docs/DEVELOPMENT.md
*.ipynb
.ipynb_checkpoints/

# Logs
*.log

Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ repos:

### Python Tools ###
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.15.20
rev: v0.16.1
hooks:
- id: ruff-check
args: [--fix]
Expand Down
Loading
Loading