Remove stray mypy.fastparse import in EDSD parser#128
Merged
Conversation
edsd.py imported `Match` from `mypy.fastparse`, which made importing the module fail at runtime (`mypy` is a dev-only dependency, and the symbol isn't even exported there). The name was never used — all `match` references are local `re.match` results / walrus assignments — so the import is simply removed. This unblocks importing pydifact.generator.runner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pydifact/generator/edsd.pyimportedMatchfrommypy.fastparse:This broke importing the module at runtime —
mypyis a dev-onlydependency (so it's absent in normal installs), and the symbol isn't
even exported from
mypy.fastparse. Becauseedsdis imported bypydifact.generator.runner, this also blocked the directory generatorentirely.
The imported
Matchname was never used: everymatchreference in thefile is a local
re.match(...)result or a walrus assignment. The importis therefore simply removed.
Verification
import pydifact.generator.edsdandimport pydifact.generator.runnernow succeed.
black --checkclean.https://claude.ai/code/session_01Q4NSyGd8CMCjjCH9gQCsvG
Generated by Claude Code