Skip to content

fix(resolve-latest): silently swallow 404 JSON leakage #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nerdalytics merged 1 commit into from
Apr 20, 2026
Merged

fix(resolve-latest): silently swallow 404 JSON leakage #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions scripts/resolve-latest.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,13 @@ while IFS='|' read -r action current_sha current_tag; do
# Get latest release tag
latest_tag=$(gh api "repos/${action}/releases/latest" --jq '.tag_name' 2>/dev/null || echo "")

# On 404 (no published releases), gh leaks the error-response JSON to
# stdout — strip it silently rather than complain about "not strict semver"
# with a raw error body. The tags-API fallback below handles the case.
if [[ "$latest_tag" == *'{'* ]]; then
latest_tag=""
fi

# Validate tag is strict semver
if [[ -n "$latest_tag" ]] && [[ ! "$latest_tag" =~ $SEMVER_RE ]]; then
echo " Warning: latest release tag '${latest_tag}' is not strict semver, trying tags API"
Expand Down