Fix shared media preview banner overflow with scrollable list#528
Merged
Conversation
Add max-height: 50vh and overflow-y: auto to .file-progress-global .list-group so the banner scrolls when many files are listed instead of overflowing the viewport. Fixes #517 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…a-preview-banner-overflow # Conflicts: # src/Recollections.Blazor.UI/wwwroot/css/site.css # src/Recollections.Blazor.UI/wwwroot/css/site.min.css
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses #517 by preventing the sticky shared-file upload/preview notification banner (.file-progress-global) from expanding beyond the viewport when many files are listed, by making the internal list scrollable.
Changes:
- Add a height constraint and vertical scrolling to
.file-progress-global .list-group(SCSS + generated CSS). - Minor UI tweak to keep the per-file upload percentage on a single line (
text-nowrap). - Update generated CSS artifacts (
site.css,site.min.css) to reflect the new styles.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Recollections.Blazor.UI/wwwroot/css/site.min.css |
Regenerated minified stylesheet to include the new scrollable list rule. |
src/Recollections.Blazor.UI/wwwroot/css/site.css |
Regenerated compiled stylesheet to include .file-progress-global .list-group scrolling/height constraints (also modifies sourcemap comment). |
src/Recollections.Blazor.UI/wwwroot/css/_file-upload.scss |
Source SCSS change adding max-height: 50vh and overflow-y: auto for the banner list. |
src/Recollections.Blazor.UI/Commons/Components/FileUploadNotification.razor |
Adds text-nowrap to the upload percentage display. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple files are shared to the app, the
.file-progress-globalbanner expands its file list without any height constraint. Because the banner issticky-top, the list grows beyond the viewport and users cannot scroll through it or reach content below.This adds
max-height: 50vhandoverflow-y: autoto the.list-groupinside the banner, making the file list scrollable when it exceeds half the viewport height. The fix applies to both the unassigned-files notification and the upload-progress notification since they share the same CSS class.Fixes #517