Skip to content

Upgrade client secret manager - #79

Merged
beraki merged 2 commits into
v1from
upgrade-client-secret-manager
Jul 15, 2026
Merged

Upgrade client secret manager#79
beraki merged 2 commits into
v1from
upgrade-client-secret-manager

Conversation

@beraki

@beraki beraki commented Jul 13, 2026

Copy link
Copy Markdown

Summary

  • Bumps @aws-sdk/client-secrets-manager from ^3.635.0 to ^3.1086.0 to resolve security vulnerabilities in transitive dependencies (including removed uuid dependency)
  • Updates @tsconfig/node18 → @tsconfig/node20 to align with the existing engines: ">=20.0.0" constraint
  • Updates README AWS SDK documentation links from v2 to v3

Changes

  • package.json — bump @aws-sdk/client-secrets-manager, update tsconfig devDep, bump version to 1.10.1
  • package-lock.json — updated lockfile reflecting new transitive dep tree (significant reduction in total packages)
  • README.md — fix three AWS SDK doc links pointing to v2 guide → v3
  • tsconfig.build.json / tsconfig.json — update @tsconfig/node18 → @tsconfig/node20

Notes

  • No source code changes — runtime behaviour is unchanged
  • The new SDK version drops node <20 support in transitive deps, consistent with the already-declared engines field

Summary by CodeRabbit

  • Release

    • Released version 1.10.1 with updated Node.js 20 compatibility.
  • Documentation

    • Updated AWS Secrets Manager guidance with accurate links for authentication, region configuration, and access control.
    • Refreshed release documentation and changelog details.
  • Maintenance

    • Updated development configuration and supporting tooling for the current Node.js environment.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Updates the package to version 1.10.1, upgrades AWS and development dependencies, switches TypeScript configuration to Node 20, adds release notes, and refreshes AWS Secrets Manager documentation links.

Changes

Release 1.10.1

Layer / File(s) Summary
Package and Node 20 configuration
package.json, tsconfig.json, tsconfig.build.json
Updates the package version and dependencies, replacing Node 18 TypeScript configuration with Node 20 configuration.
Release and AWS documentation
CHANGELOG.md, README.md
Adds the 1.10.1 changelog entry and replaces AWS SDK v2 documentation links with v3 links.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: neo-malcolm-fischer, iansu, darrenpicard25, scottkayeneo, brentcam250

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main change: upgrading the Secrets Manager client dependency.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch upgrade-client-secret-manager

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

package.json

Parsing error: Unexpected token :


Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Code Coverage

Current Coverage Difference After PR
Lines 91.80% +91.8% 😀
Functions 95.00% +95% 😀
Branches 97.96% +97.96% 😀

@beraki
beraki requested a review from DennisBarthelNeo July 13, 2026 23:04
@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v1@96584a8). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             v1      #79   +/-   ##
=====================================
  Coverage      ?   92.02%           
=====================================
  Files         ?       12           
  Lines         ?      138           
  Branches      ?       40           
=====================================
  Hits          ?      127           
  Misses        ?       11           
  Partials      ?        0           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CHANGELOG.md`:
- Around line 3-8: Update the 1.10.1 changelog entry so the development
configuration bullet clearly states that it was updated to use Node 20,
correcting the wording without changing the other release notes.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0f8dd769-f971-4368-9b7f-e9c824f44dad

📥 Commits

Reviewing files that changed from the base of the PR and between 96584a8 and e00fcd4.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (5)
  • CHANGELOG.md
  • README.md
  • package.json
  • tsconfig.build.json
  • tsconfig.json
📜 Review details
🔇 Additional comments (5)
package.json (2)

3-3: LGTM!


49-55: LGTM!

tsconfig.json (1)

2-2: LGTM!

tsconfig.build.json (1)

2-2: LGTM!

README.md (1)

122-122: LGTM!

Comment thread CHANGELOG.md

@iansu iansu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

@beraki
beraki merged commit da0a1e0 into v1 Jul 15, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants