Engcba 123/node 20 - #76
Merged
Merged
Conversation
Code Coverage
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v1 #76 +/- ##
=====================================
Coverage ? 92.02%
=====================================
Files ? 12
Lines ? 138
Branches ? 40
=====================================
Hits ? 127
Misses ? 11
Partials ? 0 🚀 New features to boost your workflow:
|
DennisBarthelNeo
requested review from
Neo-Malcolm-Fischer,
darrenpicard25,
neo-arpitkumar-patel,
neo-elgiz-abbasov and
neo-luke-joe
October 2, 2025 21:14
neo-elgiz-abbasov
previously approved these changes
Oct 2, 2025
Neo-Malcolm-Fischer
left a comment
Neo-Malcolm-Fischer
left a comment
Collaborator
There was a problem hiding this comment.
Shouldn't this be a major version change?
darrenpicard25
requested changes
Oct 2, 2025
darrenpicard25
left a comment
darrenpicard25
left a comment
Contributor
There was a problem hiding this comment.
agree with malcolm. We cant technically do a major version change as v2 is reserved for the ESM update. but we should at least do a minor version at the very least
DennisBarthelNeo
requested review from
Neo-Malcolm-Fischer,
darrenpicard25 and
neo-elgiz-abbasov
October 2, 2025 22:31
neo-elgiz-abbasov
approved these changes
Oct 2, 2025
darrenpicard25
approved these changes
Oct 2, 2025
rogersnick
reviewed
Oct 3, 2025
| @@ -1 +1 @@ | |||
| * @iansu | |||
| * @Neo-Malcolm-Fischer @darrenpicard25 | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the minimum node version to v20.