Fix concurrent credential saves losing updates - #192
Open
Liam-Doodson wants to merge 6 commits into
Open
Conversation
Liam-Doodson
force-pushed
the
fix/concurrent-save-data-loss
branch
from
August 20, 2026 15:50
0b0a523 to
02aec8d
Compare
Liam-Doodson
commented
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a bug where removing and re-adding a credential with the same name within a single process could silently lose the re-added credential. Credential mutations (add, remove, set-default, token update/clear) now read the credentials file fresh, apply their one change, and write back immediately, instead of reconciling a cached snapshot against disk.
Impact
Users adding, removing, or updating credentials will no longer see a credential silently disappear when a remove and a re-add of the same name happen within one process.