V2.0.1.dev0 req upper limits - #296
Open
pmfurlong wants to merge 4 commits into
Open
Conversation
…ng depricated numpy functions (the product function, chiefly)
Collaborator
|
Note that I tried to introduce upper version constraints in #264, but was pushed back against. I still think upper bounds are a good idea. |
Contributor
|
Thanks for this, and thanks for the comment @jgosmann ! I'm not entirely opposed to upper bounds, but this seems a bit too aggressive to me. For example, this limits the Python version to 3.8 or 3.9. We've finally got Nengo working across 3.8-3.13, so I'd prefer to also have this one work across a reasonable range, especially if the same sorts of fixes that applied to nengo could be applied here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and context:
This PR places an upper limit on the packages required for nengo spa 2.0.1
How has this been tested?
Performed a clean install of the software packages and ran simple scripts to ensure we did not get errors known to arise from version mismatch.
How long should this take to review?
This is a quick PR.
Where should a reviewer start?
review the setup.py file
Types of changes:
Checklist: