Conversation
Contributor
Author
|
Missed another interaction with #243: for the chosen VTB fractional binding + nondegenerate vectors there was also this unit test that was stripped out: # satisfies translational properties as long as the intermediate results
# are allowed to be complex
x_complex = SemanticPointer(v, algebra=algebra, dtype=np.complex128).nondegenerate()
assert np.any(np.iscomplex((x_complex ** 0.5).v))
assert np.allclose((x_complex ** (-0.5) * x_complex ** 2.5).v, (x * x).v)but I'm not sure if there's a good reason to have this combination of features. Just stating this for reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and context:
This is an experimental feature request (split off from #243 and rebased onto master), that allows one to experiment with other data types for semantic pointers, such as
np.complex64.Full support is not provided. The intended scope is for offline algebraic manipulation of SPs. In the future, one might wish to support complex types in the neural implementations as well.
Interactions with other PRs:
Assuming #243 is merged first, then this would need to be rebased such that
dtypealso passed into the new methods for SP fractional binding. Also changes may be needed to allowfractional_bindto return a complex SP if the datatype is complex.How has this been tested?
Unit tests pass, but new unit tests are needed (see 'Still to do').
How long should this take to review?
Types of changes:
Checklist:
Still to do:
vocabulary.py)