Nexage Plugin - #4
Open
pablin87 wants to merge 48 commits into
Open
Conversation
Some minor changes for the ParameterPlugin interface to make it receive a config parameter. This config is get from the settings file and is specific of each plug in(can have anything). Also make the openrtb plugin independent of the mopub exchange. The next step will be to make rubicon from this one. Aslo add initial Readme file. Add mopub specific settings for the openrtb plugin under settings/mopub_config.py Also click notifications for the openrtb plugin.
This module let you parse an adm field and put in the ip port of the click and impression url the values given.
Create two new methods to extract the path of the click and impression url. This methods are use by the rubicon exchange. Also added some test for those methods.
That is when the use_heh_endpoint is False.(aka: hitting RTBKit directly).
- Add config file - Add bid request templates - Modify settings to take the nexage config
…x requester. -Also some code of the adx_plugin...
- Fix in connection and request to send the buffer to the internet withuout encoding to utf-8. This was making the adx crash because the payload is binary protocol buffer. - add __init__ to make adx a python module (fix import errors) - add a tag_parsing funtion to get the auction_id from a html snippet. - modify settings to use by default the adx plugin
Conflicts: plugin/tag_parsing.py
+ One template for smaato BR. + ImageAd parsing support to get the clickUrl and imgUrl from the xml ad tag from the adm field.
+ It was already supported but i added a few tests to test it.
+ The adm is parsed. Then it is inspect in order to see if it is a native response. If it is native, then treat it as so. + Treating a response as native ad, let you extract the impression and click beacons from it.
This has to be with checking out from virtual machines that do not have a user in github.
Conflicts: settings/settings.py
+ add templates for mopub and pubmatic: native and direct deals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Featetures: