test: enforce stdlib-only payload with import guard - #4
Merged
Conversation
The shipped payload under plugin/src/ must import only the standard library (plus its own package); ruff/pytest stay dev-only outside plugin/. Add a two-layer guard: a denylist grep (mirrored in README's verify steps) and an AST allowlist walk that asserts every import resolves to the stdlib or the first-party package. Verified: guard fails on injected requests/azure imports, passes when clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Keep the stdlib-only guarantee enforced, not just asserted. The shipped payload under
plugin/src/must import only the standard library (plus its own package) at runtime — that's the portability/auditability promise.ruff/pytestare dev tooling and live outsideplugin/, so they never count.Changes
tests/test_stdlib_only.py— two layers:test_no_forbidden_imports: a denylist grep (msal, azure, requests, urllib3, httpx, aiohttp, msgraph, pydantic, yaml, dotenv), mirrored verbatim in README so a human and CI fail on the same offenders.test_every_import_is_stdlib_or_first_party: the real guarantee — AST-walks every import and asserts each top-level module is insys.stdlib_module_namesor the first-party package (example). Catches anything the denylist forgets.README.md— verify section now documents theuv-based dev-tooling install (pip is unavailable in some envs) and carries the same stdlib grep one-liner.Verification
Negative-tested: injecting
import requests/import azure.identityintoplugin/src/fails both guard tests; removing them passes.🤖 Generated with Claude Code