Move the packaging guard and dist-packages fix off the release branch - #49
Merged
Conversation
…ck passed `npm run package` for 0.122.4 produced 4,785 files and 126 MB, of which 4,181 files and 139 MB were `.graphify-venv` — the virtualenv built for the code-graph differential. `.gitignore` covers it; `.vscodeignore` is a separate list and covered nothing venv-shaped. `verify-package.mjs` passed it. That check asks whether required runtime dependencies are PRESENT and never whether anything unwanted has joined them, so a package eight times its normal size drew no comment — it even printed the file count in its success line. Same shape as the rest of this release: a check reporting success while measuring the wrong thing. Two guards, because the deny-list only ever catches what someone thought to name: - venv paths added to the deny-list, matched by the packages directory as well as the name, so a virtualenv called anything is caught - a file-count ceiling (1200 against a normal ~600) that fails on bulk nobody named, and prints the largest directories so the cause is visible rather than guessable Verified by repackaging with the exclusion removed: the old tree is rejected naming `.graphify-venv`, and the current one passes at 603/1200. Package is now 604 files, 97.74 MB. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Debian and Ubuntu system Python installs to `dist-packages`. Excluding only `site-packages` fixed the venv-drowns-the-graph problem on the machine it was found on and left it on the platform where a system interpreter is most likely to sit on the workspace path. Caught while writing the 0.122.4 changelog: the entry claimed both were excluded and only one was. The claim described the intent correctly; the code was the incomplete thing. Both are now pinned by the test, which had covered neither. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
✅ All checks passed
Posted by SideCarAI-Bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relocation, not new work. Two fixes were parked on
release/v0.122.4because Iwas in release mode when I wrote them. Neither has anything to do with cutting a
release, and leaving them there had a live consequence.
The consequence
Building from
main— which is what anyone does — produced a 126 MB packagewith a 139 MB Python virtualenv inside it, and
verify-package.mjspassed itwithout comment. I hit exactly that while verifying #48.
What moves
The packaging guard (cherry-picked whole):
.vscodeignorevenv exclusions,plus
verify-package.mjsgaining a venv deny-list and a file-count ceiling. Thatcheck previously asked only whether required runtime dependencies were PRESENT,
never whether anything unwanted had joined them — it printed the file count in
its own success line without reacting to it.
dist-packages: Debian and Ubuntu system Python installs there. Excludingonly
site-packagesfixed the venv problem on the machine it was found on andleft it on the platform where a system interpreter is most likely to sit on the
workspace path. Both are now pinned by the test, which had covered neither.
What stays behind
release/v0.122.4keeps only the version bump, the changelog, and the doc statsync — the things that genuinely belong to a release decision.
npm run check: green. Package from this branch: 604 files, 97.74 MB.🤖 Generated with Claude Code