The graph differential could only ever check the installed build - #46
Merged
Conversation
`graph-differential.mjs` read `.sidecar/cache/symbol-graph.json` and nothing else. That file is written by whichever extension build is installed, which lags `main` — so running the differential after a fix measured the release you happen to be running, not the code you just changed, and those diverge exactly when it matters. Concretely: after the generator fix merged, the cache was still `version: 4` and would have reported all 40 generators still missing. The check that exists to find extractor gaps would have reported a gap that was already fixed. `SIDECAR_GRAPH` now overrides the path, so a freshly built graph can be compared without disturbing the workspace cache. Run against current main this way, the differential is clean: 2 unindexed source files, both legitimately symbol-less (a type-only index and a re-export barrel), against a baseline of 7. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
✅ All checks passed
Posted by SideCarAI-Bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
graph-differential.mjsread.sidecar/cache/symbol-graph.jsonand nothingelse. That file is written by whichever extension build is installed, which
lags
main.So running the differential after a fix measured the release you happen to be
running, not the code you just changed — and those diverge exactly when it
matters.
Concretely: after #45 merged, the cache was still
version: 4and wouldhave reported all 40 generators still missing. The check that exists to find
extractor gaps would have reported a gap that was already fixed.
SIDECAR_GRAPHnow overrides the path, so a freshly built graph can becompared without disturbing the workspace cache.
Result against current main
Both remaining misses are legitimately symbol-less:
sdk/index.ts(type-onlyexports) and
webview/handlers/messageUtils.ts(pureexport * frombarrel).anthropicStreamTranslate.tsandcompletions/provider.tshave dropped offthe list.
This is the check that found both the 221-constant gap and the generator gap.
It now reports on the code rather than on whatever happens to be installed.
🤖 Generated with Claude Code