fix: overflow of device-name - #231
Merged
ShortDevelopment merged 2 commits intoOct 2, 2025
Merged
Conversation
## Issue In the share-dialog long device-names might not be visible. ## Context We had set `android:ellipsize="marquee"` in the layout but that only works when the view is "selected". ## Solution We now wrap the text to a max of two lines. The bluetooth-beacon clips the device-name anyway. But in case the text still overflows the start will be clipped to preserve the part that likely identifies a device.
ShortDevelopment
deleted the
bugfix/cant-see-full-device-names-on-share-dialog/230
branch
October 2, 2025 16:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
In the share-dialog long device-names might not be visible.
Context
We had set
android:ellipsize="marquee"in the layout but that only works when the view is "selected".Solution
We now wrap the text to a max of two lines.
The bluetooth-beacon clips the device-name anyway. But in case the text still overflows the start will be clipped to preserve the part that likely identifies a device.