Repository navigation
chore: nodes accept peer with same or higher protocol version - #1778
Merged
kevindeforth merged 3 commits intoJan 16, 2026
Merged
Conversation
SimonRastikian
previously approved these changes
Jan 16, 2026
gilcu3
previously approved these changes
Jan 16, 2026
netrome
approved these changes
Jan 16, 2026
netrome
left a comment
netrome
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for doing this, looking forward to having a more upgradable network layer!
|
|
||
| let other_protocol_version = u32::from_be_bytes(other_handshake[1..].try_into().unwrap()); | ||
| if other_protocol_version != MPC_PROTOCOL_VERSION { | ||
| if other_protocol_version < MPC_PROTOCOL_VERSION { |
Collaborator
There was a problem hiding this comment.
For future reference, we plan to keep track of the agreed protocol version in a future release so newer nodes will know which version of the protocol they need to "speak". However, in this case the old nodes are simply "trusting" newer nodes to decide if they want to accept the connection and not, and the responsibility is on the newer nodes to communicate in a backwards compatible way.
gilcu3
approved these changes
Jan 16, 2026
kevindeforth
enabled auto-merge
January 16, 2026 09:20
kevindeforth
deleted the
kd/1777-prepare-network-protocol-for-upgrades
branch
January 16, 2026 10:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1777, in preparation of further network updates.
for context: #1778 (comment)