Skip to content

fix(network): add small timeout between establishing new persistent connections - #1775

Closed
kevindeforth wants to merge 3 commits into
mainfrom
kd/timeout-investigation
Closed

kevindeforth wants to merge 3 commits into
mainfrom
kd/timeout-investigation

Conversation

@kevindeforth

@kevindeforth kevindeforth commented Jan 15, 2026 •

Copy link
Copy Markdown
Contributor

resolves #1829


before #1831:
A timeout of 100 ms makes many tests fail.
A timeout of 10 ms seems to pass at least locally.
That's slightly concerning, as we would like a timeout, so we don't accidentally DDOS the receiving node.

@kevindeforth kevindeforth changed the title (Fails): add small timeout between establishing new persistent connections fix(network): add small timeout between establishing new persistent connections Jan 15, 2026
@kevindeforth
kevindeforth force-pushed the kd/timeout-investigation branch from ce20fba to 4adee9c Compare January 15, 2026 17:15
@kevindeforth
kevindeforth force-pushed the kd/timeout-investigation branch from 4adee9c to cf2f341 Compare January 16, 2026 08:25
Base automatically changed from kd/1759-network-fix to main January 16, 2026 09:44
@kevindeforth
kevindeforth force-pushed the kd/timeout-investigation branch from ec682c4 to 9dfa418 Compare January 22, 2026 14:57
@kevindeforth
kevindeforth changed the base branch from main to kd/1783-improve-p2p-handshake January 22, 2026 14:58
@kevindeforth
kevindeforth force-pushed the kd/1783-improve-p2p-handshake branch 2 times, most recently from 8aed2fb to 68dba27 Compare January 28, 2026 12:03
Base automatically changed from kd/1783-improve-p2p-handshake to main February 4, 2026 09:32
@kevindeforth

Copy link
Copy Markdown
Contributor Author

closing this, it seems to be a persistent issue.

@netrome
netrome deleted the kd/timeout-investigation branch August 3, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

investigation: check if adding timeout in Persistent connection still breaks after improving handshake

1 participant