Repository navigation
test: handle transaction nonces locally - #1769
Merged
Merged
Conversation
gilcu3
force-pushed
the
1606-flaky-pytests-since-nearcore-210-2
branch
2 times, most recently
from
January 15, 2026 13:34
42f52bf to
ee441d9
Compare
gilcu3
commented
Jan 15, 2026
Comment on lines
496
to
498
| nonce = cluster.contract_node.near_node.get_nonce_for_pk( | ||
| candidate_account_id, creator_key.pk | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
this is the only remaining place where we do not manage the nonce. The reason is a bit complicated to explain, but basically is related to the dance we do here to create accounts and access_keys. Given that we are anyway moving away from pytests, I did not want to spend too much time refactoring that. The bug we were hitting should not re-appear here, so it should be fine.
gilcu3
force-pushed
the
1606-flaky-pytests-since-nearcore-210-2
branch
from
January 15, 2026 13:38
ee441d9 to
1aea542
Compare
DSharifi
suggested changes
Jan 15, 2026
DSharifi
left a comment
DSharifi
left a comment
Contributor
There was a problem hiding this comment.
Thanks for cleaning this up.
Blocker:
- Can you just change the complex list comprehension to a simple for loop?
DSharifi
previously approved these changes
Jan 15, 2026
DSharifi
left a comment
DSharifi
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing.
Approved with a suggestion
DSharifi
approved these changes
Jan 15, 2026
gilcu3
enabled auto-merge
January 15, 2026 16:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1606 (again)