Repository navigation
chore: remove dead Python code - #1761
Merged
Merged
Conversation
pbeza
changed the title
pbeza
force-pushed
the
pab/python-cleanup
branch
from
January 14, 2026 17:44
24bf41b to
4fb2440
Compare
pbeza
force-pushed
the
pab/python-cleanup
branch
from
January 14, 2026 17:48
4fb2440 to
b8442ed
Compare
pbeza
marked this pull request as ready for review
January 14, 2026 17:52
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes unused Python code from the pytest test suite, including dead methods, classes, imports, and constants that are no longer referenced anywhere in the codebase.
Changes:
- Removed unused methods from MPC node and cluster classes
- Removed unused classes and constants from contracts module
- Removed unused helper methods from participants and CKD modules
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pytest/common_lib/shared/mpc_node.py | Removed change_contract_id method and ruamel.yaml import |
| pytest/common_lib/shared/mpc_cluster.py | Removed run_all and get_config methods |
| pytest/common_lib/contracts.py | Removed json import, constants, classes, and enum values for contract updates |
| pytest/common_lib/contract_state.py | Removed ids and by_id methods from Participants class |
| pytest/common_lib/ckd.py | Removed b58encode_g2 function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
netrome
approved these changes
Jan 14, 2026
netrome
left a comment
netrome
left a comment
Collaborator
There was a problem hiding this comment.
Nice, thanks for spotting and removing the dead code! 🙏
pbeza
enabled auto-merge
January 14, 2026 19:09
gilcu3
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1762
Inspired by #1725 (comment).