Repository navigation
fix: enable TCP_KEEPALIVE for network connections - #1752
Merged
Merged
Conversation
DSharifi
approved these changes
Jan 14, 2026
netrome
approved these changes
Jan 14, 2026
netrome
left a comment
netrome
left a comment
Collaborator
There was a problem hiding this comment.
As with any change I'd like to see some test coverage, but since this is a current production issue and a tiny PR I'm okay skipping that for now.
| sha2 = "0.10.9" | ||
| sha3 = "0.10.8" | ||
| signature = "2.2.0" | ||
| socket2 = "0.6.1" |
Collaborator
There was a problem hiding this comment.
I'm surprised we need a depdency for this, but this looks like the way to do it.
Contributor
There was a problem hiding this comment.
It's from the rust-lang team so should be fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1751