Repository navigation
feat(launcher): Add ability to use the launcher also for non tee setups. - #1735
Merged
Merged
Conversation
barakeinav1
force-pushed
the
launcher-nontee-support
branch
3 times, most recently
from
January 11, 2026 12:52
6292270 to
7b0d1af
Compare
barakeinav1
force-pushed
the
launcher-nontee-support
branch
from
January 11, 2026 16:08
7b0d1af to
c12dbe0
Compare
barakeinav1
force-pushed
the
launcher-nontee-support
branch
from
January 13, 2026 08:47
e04b57b to
4ae540c
Compare
DSharifi
previously approved these changes
Jan 14, 2026
gilcu3
requested changes
Jan 14, 2026
Contributor
There was a problem hiding this comment.
Looks quite good. I have only two blockers, and a few suggestions:
Comment on lines
+485
to
+488
| if not is_unix_socket(DSTACK_UNIX_SOCKET): | ||
| raise RuntimeError( | ||
| f"PLATFORM=TEE requires dstack unix socket at {DSTACK_UNIX_SOCKET}." | ||
| ) |
Contributor
There was a problem hiding this comment.
I guess this is orthogonal to the issue? Something missing from before?
Contributor
Author
There was a problem hiding this comment.
related, not orthogonal. (let says 42 degrees)
If we don't have DSTACK_UNIX_SOCKET when running in TEE mode, this is a critical failure.
better to stop right away.
Contributor
There was a problem hiding this comment.
just for consistency
Suggested change
| image: nearone/mpc-launcher@sha256:72f16f1d1ca9119f5c19cb3ec7f6338949e2ad3082bd01ba2099c6649e845f61 |
Contributor
There was a problem hiding this comment.
Thank you very much for this doc!
barakeinav1
force-pushed
the
launcher-nontee-support
branch
from
January 14, 2026 10:23
5fa62d7 to
b4eedb4
Compare
DSharifi
previously approved these changes
Jan 14, 2026
Contributor
Author
let add this as a separate task Add CI job to validate NON-TEE launcher-based MPC deployment |
barakeinav1
force-pushed
the
launcher-nontee-support
branch
from
January 14, 2026 12:09
87988f4 to
6fdf87a
Compare
DSharifi
previously approved these changes
Jan 14, 2026
gilcu3
previously approved these changes
Jan 14, 2026
gilcu3
left a comment
Contributor
There was a problem hiding this comment.
Thank you, left 2 nits in the doc
gilcu3
approved these changes
Jan 14, 2026
barakeinav1
enabled auto-merge
January 14, 2026 14:48
DSharifi
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1590
This PR allows the MPC launcher to run both inside TEEs and outside TEEs using the same orchestration flow, without weakening any existing TEE security guarantees.
A new measured PLATFORM mode (TEE / NONTEE) explicitly controls whether dstack/attestation is required. TEE behavior remains fail-closed and fully attested, while non-TEE deployments can exercise the launcher logic without dstack.
High-level changes
tests:
added a few python tests.
I also run a manually test an started an MPC node using the launcher