Repository navigation
Fix contract integration tests #1144
Description
Background
In #1099 we added two contract integration tests to the code base.
- If
test_participant_kickout_after_expirationis a unit test, we can skip the last parts of the test (step 6-9) or break them out to a separate unit test. Also the test should be moved from thecontract/testsdirectory closer to the logic they are testing and they should try to use existing helper functions for theVmContextframework to avoid code duplication. - If it's an integration test, it should use the existing sandbox.
- The cleanup test is redundant, c.f. chore: index nodes by account id & TLS key in TEE State #1120 (comment)
User Story
No response
Acceptance Criteria
Move the logic to unittests or make an actual integration test
Compare expected NodeIds with actual NodeIds instead of lazily comparing the number of attestations / participants
Activity
netrome commentedon Sep 18, 2025
Note: I would prefer to keep the unit tests. I'd be happy to have them moved and complemented by integration tests but anything that we can test as unit tests should be tested as unit tests, as it provides a much faster feedback loop when debugging and developing.
test: fix contract integration tests