Skip to content

#143 arialabel problems #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndunand merged 2 commits into from
Feb 11, 2026
Merged

#143 arialabel problems #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1779acc
Fix: arialabel templating must be escaped to prevent e.g. double quot…
danowar2k Feb 11, 2026
085c124
Fix: aria-label should not contain HTML tags
danowar2k Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions classes/output/formulation_and_controls.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ public function export_for_template(renderer_base $output) {
$cellcontext['colindex'] = $colindex;
$cellcontext['responseparamname'] = $responseparamname;
$a = [
'itemshorttext' => $row->shorttext,
'answershorttext' => $col->shorttext
'itemshorttext' => strip_tags($row->shorttext),
'answershorttext' => strip_tags($col->shorttext)
];
$cellcontext['arialabel'] = lang::get('cellarialabel', (object) $a);

Expand Down
4 changes: 2 additions & 2 deletions templates/question.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,10 @@ Expired question: This can happen in preview mode.
{{#cells}}
<td class="cell {{ cellclass }}">
{{#multiple}}
<input type="checkbox" name="{{ responseparamname }}" value="1"{{#isreadonly}} disabled="disabled"{{/isreadonly}}{{#ischecked}} checked="checked"{{/ischecked}} aria-label="{{{ arialabel }}}">
<input type="checkbox" name="{{ responseparamname }}" value="1"{{#isreadonly}} disabled="disabled"{{/isreadonly}}{{#ischecked}} checked="checked"{{/ischecked}} aria-label="{{ arialabel }}">
{{/multiple}}
{{^multiple}}
<input type="radio" name="{{ formfieldname }}" value="{{ colindex }}"{{#isreadonly}} disabled="disabled"{{/isreadonly}}{{#ischecked}} checked="checked"{{/ischecked}} aria-label="{{{ arialabel }}}">
<input type="radio" name="{{ formfieldname }}" value="{{ colindex }}"{{#isreadonly}} disabled="disabled"{{/isreadonly}}{{#ischecked}} checked="checked"{{/ischecked}} aria-label="{{ arialabel }}">
<input hidden type="checkbox" id="{{ uniqid }}_{{ cellclass }}" name="{{ responseparamname }}" value="1"{{#ischecked}} checked="checked"{{/ischecked}} aria-hidden="true">
<label hidden for="{{ uniqid }}_{{ cellclass }}">{{ cellclass }}</label>
{{/multiple}}
Expand Down