#77 override rebase - #142
Conversation
e997367 to
866b626
Compare
6ca32d9 to
54cb51e
Compare
|
Hi. So I finally had the time to finish my pull request for autopassing rows. I've rebased again and pushed to my repo. Github Actions right now has problems it seems. You shouldn't do anything before Actions ran once. I tested locally in a Moodle Docker environment with Behat and PHPUnit under PHP 8.1, but not more. Once Github Actions ran, I'll comment again. |
|
One note: This PR contains a change done because of a Moodle tracker issue: 9123dfb If you want, I can extract it into another PR. |
54cb51e to
fb97642
Compare
|
Of course there are errors. Be right back... |
cce9b8a to
db61a7e
Compare
… the point for it, i.e. letting rows "autopass" Teachers should be able to e.g. give points to everyone for badly worded questions. - Settings: Add global setting to enable the feature, defaults to off - Database: Add boolean autopass field to rows - Logic: Every grading allows autopassing rows - Logic: The first version of a question should not be able to set or use autopassing - Logic: Regrading now prevents going from single to multiple or back if the number of correct answers are different - Logic/Fix: Clean matrix data only at the end of functions that builds that data to prevent duplicates - Backup/Restore: Adapt values if question version > v1 is restored as a first version - Import/Export: Ignore when importing, always export as false - Editing: If enabled, display autopass column for question versions > v1 - Editing: Prevent showing autopass column when duplicating a question - Response Feedback: Show an icon and an explaining message when a row is autopassed - Tests: Created and adapted PHPUnit and Behat tests
db61a7e to
2594451
Compare
|
Okay. It seems I'd forgotten something or rather didn't test the last minute changes I made: A late game check to prevent storing autopass values for the matrix row of a question with version 1. Ugh, I don't like how Moodle handles all this. This is all inherently badly testable. All those lib functions which can't be mocked etc etc. No strategy pattern in use most of the time. Just meh. Okay, tests are now green. Only the tests were wrong, the code was working before :-D We're now "eagerly" awaiting your opinion and if and when you will merge the PR. |
|
Hi @danowar2k thanks for all your work on this. i've deployed this on our testing site and we'll get back to you. |
|
Tested and works as expected. |
2 participants
I've cherry picked the autopass commits into a new branch because the old branch contained a big swath of old code that was already rebased and this was easier than rebasing the old branch.
So this should now contain only the autopass changes and probably solves #77.
What we probably need to do now:
I also have to talk with the exam people about all this again...So this gets to be marked as a draft at first again...