frontend updates for API changes#184
Conversation
- sort protein & rna differently - sort by data source - change shading map with different data sources - fix for new gtex table structure
refactor to use the same header for all the components
client side changes for pharos 3.13
fix tutorial button
add banner about being under review for compliance with Administration directives
fix styling on banner
updated about page
fix links to TCRD
remove link to Jira issue queue
add link to linkedOmicsKb
update about page
# Conflicts: # Dockerfile
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c83efa8b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const selectedCase = UseCaseData.getUseCases().find(c => c.anchor === subpath); | ||
| title = title + ' - ' + selectedCase.title; |
There was a problem hiding this comment.
When navigating to /usecases/:id, this code assumes every :id exists in UseCaseData; for an unknown or mistyped ID, find(...) returns undefined and selectedCase.title throws at runtime. Because this executes in the root NavigationEnd handler, a bad deep link can trigger an exception on navigation instead of gracefully falling back to a generic/use-path title.
Useful? React with 👍 / 👎.
| withPreloading(PharosPreloader) | ||
| ), | ||
| importProvidersFrom( | ||
| ServiceWorkerModule.register('ngsw-worker.js', {enabled: true}), |
There was a problem hiding this comment.
Registering the Angular service worker with enabled: true activates SW caching in all environments, including development and test deployments. That can cause stale assets and hard-to-reproduce behavior during QA/debugging, and it regresses the previous production-gated registration behavior. The flag should be tied to a production/dev-mode condition instead of being unconditionally enabled.
Useful? React with 👍 / 👎.
7 participants
No description provided.