Remaining Entities and Tiles by Wilyicaro · Pull Request #664 · nbcraft-org/nbcraft

Wilyicaro · 2026-07-02T20:20:58Z

Entities

Minecart (default, chest and furnace)
Boat
Painting
Wolf
Lightning Bolt

Tiles and Tile Entities

Mob Spawner
Sign
Record Player (only the tile entity)
Piston and Sticky Piston (PistonBaseTile, PistonHeadTile and MovingPistonTile)
Mushroom (it was using Bush beforehand)

Related Items

Saddle
Minecart
Boat
Painting
Sign
Piston

Misc and Fixes

Fixed Ghast shooting at the wrong direction
Riddeable Pig
Reduced repeated code between the projectiles (it could be better)
Weather (rain and snow, with its own shader material)
Tile Entity Renderer
Enhanced the rendering of tile faces, so it supports face rotation and doesn't repeat code for different face directions
BiomeSource supports checking bigger areas now
ImprovedNoise and PerlinNoise are accurate to Java (still using floats)

…between projectiles

… blocks

…provements to HashMapFunction

…yicaro/nbcraft into remaining-entities-and-tiles

Un1q32 · 2026-07-03T22:46:07Z

 //#define ENH_RENDER_HAND_ARMOR            // Render the right arm of the chestplate you are wearing on top the first-person hand.
 #define ENH_SAVE_REMOTE_PLAYERS            // Save remote player data on the server, such as inventory, position, health, etc.
-//#define ENH_BETA_1_7_TERRAIN_ATLAS       // Enables support for the vertical shift of some textures from Beta 1.7, such as cake
+#define ENH_BETA_1_7_TERRAIN_ATLAS         // Enables support for the vertical shift of some textures from Beta 1.7, such as cake


The default terrain.png needs to be updated to accommodate this.

BrentDaMage

Partial review. More tomorrow.

BrentDaMage · 2026-07-06T12:15:52Z

+#define AKEYCODE_FORWARD_DEL   VK_DELETE
+#define AKEYCODE_ARROW_LEFT    VK_LEFT
+#define AKEYCODE_ARROW_RIGHT   VK_RIGHT
+#define AKEYCODE_DEL               VK_BACK


fix indentation

BrentDaMage · 2026-07-06T12:17:29Z

+		"blendDst": "OneMinusSrcAlpha",
+
+		"vertexShader" : "shaders/uv.vertex",
+		"fragmentShader" : "shaders/texture_ccolor.fragment"


Are you sure we need ccolor here? I don't think rain or snow ever gets recolored live, unless we need it for alpha or something?

Yes, we need it for the alpha

BrentDaMage · 2026-07-06T12:17:48Z

+			"Blending",
+			"Textured"],
+
+		"blendSrc": "SourceAlpha",


I believe these are default and don't need to be specified.

BrentDaMage · 2026-07-06T12:20:11Z

+{
+    int x = m_width / 2 - 50;
+    int y = m_height / 4 + 20;
+    VirtualKeyboard keyboard;


new line above this

BrentDaMage · 2026-07-06T12:20:19Z

+    VirtualKeyboard keyboard;
+    keyboard.rect = IntRectangle(x / Gui::GuiScale, y / Gui::GuiScale, (x + 100) / Gui::GuiScale, (y + 100) / Gui::GuiScale);
+    m_pMinecraft->m_pPlatform->showKeyboard(0, keyboard);
+    m_btnDone.m_xPos = m_width / 2 - 100;


new line above this

BrentDaMage · 2026-07-06T12:40:24Z

+	TileData auxValue = m_pLevel->getData(pos);

-	m_pMinecraft->m_pParticleEngine->destroyEffect(pos);
+	m_pMinecraft->m_pParticleEngine->destroyEffect(pos, pTile->m_ID, auxValue);


BrentDaMage · 2026-07-06T12:41:44Z

 	_addRenderer(Entity::RENDER_GIANT,        new GiantMobRenderer(   new ZombieModel,   0.5f, 6.0f));
 	_addRenderer(Entity::RENDER_SLIME,        new SlimeRenderer(      new SlimeModel(16), new SlimeModel(0), 0.25f));
 	_addRenderer(Entity::RENDER_GHAST,        new GhastRenderer());
+	_addRenderer(Entity::RENDER_WOLF,		  new WolfRenderer(new WolfModel, 0.5f));


make indentation in-line with the others up top

BrentDaMage · 2026-07-06T12:41:58Z

+	_addRenderer(Entity::RENDER_MINECART,	  new MinecartRenderer());
+	_addRenderer(Entity::RENDER_BOAT,		  new BoatRenderer());
+	_addRenderer(Entity::RENDER_PAINTING,	  new PaintingRenderer());
+	_addRenderer(Entity::RENDER_LIGHTNING_BOLT, new LightningBoltRenderer());


make all of the others in-line with this

BrentDaMage · 2026-07-06T12:45:06Z

+
+				var10.begin(mce::PRIMITIVE_MODE_TRIANGLE_STRIP, 10);
+				float var31 = 0.5f;
+				var10.color(0.9f * var31, 0.9f * var31, 1.0f * var31, 0.3f);


we could probably get away with just doing the currentShaderColor here and switching off of the vertex-color entity shader.

BrentDaMage · 2026-07-06T12:45:11Z

+		}
+		Lighting::turnOn();
+	}
+}


BrentDaMage

Partial review. Half way there.

BrentDaMage · 2026-07-06T23:20:52Z

+            p1 = p;
+
+        cPos.x += p->x - smoothPos.x;
+        cPos.y += (p0->y + p1->y) / 2.0 - smoothPos.y;


add the fs here

BrentDaMage · 2026-07-06T23:27:05Z

+    {
+        MatrixStack::Ref tileMatrix = MatrixStack::World.push();
+        bindTexture(C_TERRAIN_NAME);
+        float ss = 0.75F;


make Fs lowercase and make

BrentDaMage · 2026-07-06T23:30:05Z

+
+protected:
+	Model* m_pModel;
+	TileRenderer m_tileRenderer;


Shouldn't we be using a the singleton here or something instead of making a new one specifically for this? Better yet, we should do what the FallingTileRenderer does.

BrentDaMage · 2026-07-06T23:30:26Z

+    bindTexture("art/kz.png");
+    const Painting& painting = (const Painting&)pEntity;
+    PaintingType& motive = painting.getPaintingType();
+    float s = 0.0625F;


make constexpr and make Fs lowercase.

BrentDaMage · 2026-07-06T23:30:30Z

+
+void PaintingRenderer::render(const Entity& pEntity, const Vec3& pos, float rot, float b)
+{
+    m_random.setSeed(187L);


remove the L

BrentDaMage · 2026-07-07T01:03:13Z

+
+	if (m_life >= 0)
+	{
+		constexpr float var6 = 3.0;


BrentDaMage · 2026-07-07T01:03:23Z

+	void tick() override;
+	virtual bool shouldRender(Vec3& camPos) const override;
+
+public:


private above public

BrentDaMage · 2026-07-07T01:07:16Z

+    addSpawnData(EntityCategories::ANIMAL, EntityType::SHEEP, 12);
+    addSpawnData(EntityCategories::ANIMAL, EntityType::PIG, 10);
+    addSpawnData(EntityCategories::ANIMAL, EntityType::CHICKEN, 10);
+    addSpawnData(EntityCategories::ANIMAL, EntityType::COW, 10);


Aren't Cows supposed to be 8? Where'd 10 come from?

BrentDaMage · 2026-07-07T01:08:47Z

+        return true;
+
+    return false;
+}


add new line

BrentDaMage · 2026-07-07T01:10:00Z

+		{
+		}
+
+		virtual bool canSpawn(Level& level, EntityType::ID id, const TilePos&) const { return true; }


Make this abstract, aka = 0

Wilyicaro and others added 8 commits June 30, 2026 14:17

fix: ghast shooting at the wrong direction and reduced repeated code …

59b0b31

…between projectiles

feat: remaining entities and particles, weather and related items and…

98d2a6c

… blocks

feat: missing tiles and tile entities (except for the bed...), and im…

6f855fb

…provements to HashMapFunction

chore: wrong source file

3d47302

chore: another wrong source file in the cmakelists

7d91b8f

fix: lazy enum class replacement for c++ 98

43e4fbd

Merge branch 'remaining-entities-and-tiles' of https://github.com/Wil…

be7c035

…yicaro/nbcraft into remaining-entities-and-tiles

fix: replaced PushReaction with PushReaction::Type

9fb514e

Un1q32 reviewed Jul 3, 2026

View reviewed changes

BrentDaMage requested changes Jul 6, 2026

View reviewed changes

BrentDaMage requested changes Jul 7, 2026

View reviewed changes

Uh oh!

Conversation

Wilyicaro commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Entities

Tiles and Tile Entities

Related Items

Misc and Fixes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BrentDaMage left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BrentDaMage left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Wilyicaro commented Jul 2, 2026 •

edited

Loading