Merge CPU and Dev container to share code and configuration files#122
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actually why do we need GPU-enabled container for development for Orcapod? Do we have something we specifically test GPU features?
There was a problem hiding this comment.
Not yet, but soon. I could also add the GPU feature and a the test for it.
There was a problem hiding this comment.
If we don't currently need GPU-based containers, I'd be in favor of removing it? How did you plan on using the GPU image?
There was a problem hiding this comment.
Anyway I'll go ahead and merge but we will follow up in a separate issue to discuss and simplify the devcontainer.
There was a problem hiding this comment.
I was planning to add a test to check if the Pod requires a gpu that it launches with one. The issue I ran into is that github action doesn't have GPU's by default so those GPU tests would fail. Since a lot of people will use this for machine learning, testing if orca pod handle GPU Pods correctly is needed.
There was a problem hiding this comment.
https://docs.github.com/en/actions/concepts/runners/larger-runners
I did find this a while ago but I am not sure if it would cost us more to get access to a GPU Github Action Runner.
The other option is to write a test as a switching code, where it will just return success if there is no GPU, and if there is a GPU available, then actually test it.
2 participants
Merge the two CPU and GPU dev containers to share as much common resources as possible.
Fixes PLT-298