Comments#1
Open
mattswann wants to merge 2 commits into
Open
Conversation
added 2 commits
May 4, 2016 15:43
It's a good idea to add as many comments as you can in these files. Comments help explain what the route and method is doing. If you wanted to clean it up a little you could consider moving the helper methods to another file.
It would be a good idea to add a read me to explain things like the following... The Brief The User in mind The Technology Used Things you learned Things you'd improve in version 2.0 Anything else you want to explain about the app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Nat,
Awesome App! You managed to do so much in a week!
I think that a few more comments in your code and a README would defiantly take this app to the next level.
Have a look at this for ENV help http://blog.honeybadger.io/ruby-guide-environment-variables/
I noticed that you have included Bootstrap but you're not really using the best part. The grid system. I'd suggest just coding the css your self if you're not going to use the grid.
Really good work! I can't wait to see what you come up with next.
Cheers,
Matt Swann